Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This library needs breaking up #10

Open
amrc-benmorrow opened this issue Oct 19, 2023 · 3 comments · Fixed by AMRC-FactoryPlus/js-service-client#1 or #21
Open

This library needs breaking up #10

amrc-benmorrow opened this issue Oct 19, 2023 · 3 comments · Fixed by AMRC-FactoryPlus/js-service-client#1 or #21

Comments

@amrc-benmorrow
Copy link
Contributor

This library has grown much too large. It needs breaking up into at least these pieces:

  • The ServiceClient and interfaces
  • The WebAPI
  • The Sparkplug Node interface
  • The database interface

This module then needs to pull the pieces back in, for compatibility.

@amrc-benmorrow
Copy link
Contributor Author

We should probably also move the base Docker image into a different repo. The image doesn't have the library preinstalled (because I can't work out how to do that with NPM) and so the release cadence for library and image is quite different.

@amrc-benmorrow
Copy link
Contributor Author

The image move is done; base images are now in acs-base-images. Splitting the library up has become more urgent: the gssapi and pg deps are preventing webpacking of the client code.

@amrc-benmorrow
Copy link
Contributor Author

Reopening as the remaing pieces still need breaking out.

@amrc-benmorrow amrc-benmorrow reopened this Apr 3, 2024
@amrc-benmorrow amrc-benmorrow linked a pull request Apr 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant