Import ServiceClient from js-service-client #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't want to maintain this code in two places going forwards, but I also don't want to migrate all users over right now.
Remove deps we no longer need. Remove 'node:' prefix on imports; despite the NodeJS recommendation, it actually makes code less portable, as bundlers don't like it.
This is cleaner, but is also backwards-incompatible.
Previously Debug will have done this automatically. It would be better to push this right out but this is old and slightly nasty code and I don't want to break it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the ServiceClient implementation from this package and import from
@amrc-factoryplus/service-clientinstead.This is a backwards-incompatible change! See the README.