-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance docs #878
Performance docs #878
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need a recommended checklist or something similar for people that are handed a model and data and want to run it performantly on a new server. This would probably be something like:
- run sharrow compile with a small hh sample size and save the sharrow cache to be used in subsequent runs
- run memory profiling with a 10% or so sample to determine memory requirements
- configure chunking if necessary
- Run full sample in multiprocessing with 10 cores
- Experiment with number of cores and threads to find the best performance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to David's comments. I'd like to add:
- We did a lot of memory and run time profiling in phase 9A. It would be nice to add an
Example Model Performance
section in the user docs to document the example 1-zone and 2-zone model performance. - Recommend setting
sharrow: test
to catch components that are sharrow incompatible if a region is running sharrow for the first time with their model. It will be helpful to give some guidance on how to find the problematic expressions. It be helpful to also document some example incompatible expressions and how to fix them, e.g., move them into preprocessor.
I will open another PR with a summary of performance results and a description of the new two "canonical" examples. |
I believe I have addressed all the review comments. @dhensle @i-am-sijia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Documentation updates to explain how users can tune ActivitySim models for decent performance.