Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharrow fix all #15

Merged
merged 16 commits into from
May 22, 2024
Merged

Sharrow fix all #15

merged 16 commits into from
May 22, 2024

Conversation

jpn--
Copy link
Member

@jpn-- jpn-- commented May 7, 2024

This PR makes all necessary changes to get sharrow working on this model from head to toe.

  • Use new landuse_orig_* variables in accessibility.
  • Change fillna to nan_to_num for sharrow compatability.
  • Fix various math and overflow errors in model specs.
  • Disable fastmath in components that have NaN values that must be processed.
  • Use omx_ignore_patterns setting to skim loading redundant bike skims.

These changes also require ActivitySim/activitysim#867

@jpn-- jpn-- requested review from dhensle and i-am-sijia May 14, 2024 17:39
Copy link
Contributor

@i-am-sijia i-am-sijia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed Trip Destination choice. Sharrow is still turned off, at least in its settings. I realized this after looking at the latest benchmarking result.

@jpn-- jpn-- merged commit 4522b88 into ActivitySim:main May 22, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants