refactor: trait usage standardisation

[VanWeapon]

Description of changes

• remove old useage of trait checking still found in code

Reasons for changes

• standardisation and legibility

Related links

• found thanks to investigating trait effects and found a number of old usages which are probably broken in 0.10+ because of the new 8 trait limit

Summary by Sourcery

Standardize trait usage by replacing string comparisons with a dedicated function.

Enhancements:

• Replace string-based trait checking with scr_has_adv and scr_has_disadv functions.

Tests:

• Update tests to reflect the changes in trait checking.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request refactors trait usage by replacing string-based trait checking with the functions scr_has_adv and scr_has_disadv.

File-Level Changes

Change	Details	Files
Replaced string-based trait checking related to advantages with scr_has_adv.	Used the function scr_has_adv for the following traits: Ambushers, Bolter Drilling, Enemy: Eldar, Enemy: Fallen, Enemy: Orks, Enemy: Tau, Enemy: Tyranids, Siege Masters, Devastator Doctrine, Assault Doctrine, Kings of Space, Daemon Binders, Tech-Brothers, Never Forgive, Tech-Scavengers, Lightning Warriors, Boarders, Crafters, Psyker Abundance, Reverent Guardians, Siege Masters.	objects/obj_fleet/Create_0.gml scripts/scr_powers/scr_powers.gml scripts/scr_draw_unit_image/scr_draw_unit_image.gml objects/obj_controller/Alarm_5.gml objects/obj_popup/Draw_0.gml objects/obj_star_select/Draw_64.gml scripts/scr_squads/scr_squads.gml scripts/scr_unit_traits/scr_unit_traits.gml
Replaced string-based trait checking related to disadvantages with scr_has_disadv.	Used the function scr_has_disadv for the following traits: Black Rage, Shitty Luck, Warp Touched, Doom, Psyker Intolerant, Tech-Heresy, Tolerant.	objects/obj_fleet/Create_0.gml objects/obj_ncombat/Alarm_5.gml scripts/scr_powers/scr_powers.gml objects/obj_controller/Alarm_5.gml scripts/scr_kill_unit/scr_kill_unit.gml objects/obj_controller/Create_0.gml objects/obj_popup/Step_0.gml scripts/scr_marine_struct/scr_marine_struct.gml scripts/scr_random_event/scr_random_event.gml scripts/scr_enemy_ai_b/scr_enemy_ai_b.gml scripts/scr_enemy_ai_d/scr_enemy_ai_d.gml scripts/scr_garrison/scr_garrison.gml scripts/scr_player_combat_weapon_stacks/scr_player_combat_weapon_stacks.gml scripts/scr_specialist_point_handler/scr_specialist_point_handler.gml scripts/scr_add_artifact/scr_add_artifact.gml
Removed string-based trait checking variables.	Removed the variables strin and strin2 which were previously used for string-based trait checking, as they are no longer needed after refactoring.	objects/obj_ini/Create_0.gml scripts/scr_load/scr_load.gml scripts/scr_save/scr_save.gml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @VanWeapon - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[EttyKitty]

@VanWeapon, I'm okay with merging this, as it's also a major fix.

[EttyKitty]

@sourcery-ai review

[sourcery-ai]

Hey @VanWeapon - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}