fix Ingredient Audio and Video boolean type casting #2909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
added
backport-to-7.0-stable
Currently boolean values of ingredient video and audio
are stored as strings ("0"/"1") in the data column JSON.
Cast to Boolean before we save to make this booleans.
tvdeyen
force-pushed
the
fix-video-booleans
branch
from
41d416b
to
0ec35d5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2909 +/- ##
=======================================
Coverage 95.96% 95.97%
=======================================
Files 232 232
Lines 6273 6279 +6
=======================================
+ Hits 6020 6026 +6
Misses 253 253 ☔ View full report in Codecov by Sentry. |
|
What about the getters? Should those be overwritten, too, to make sure existing values in the database aren't strings/numbers? |
|
Thought about it, but current users will have their solution if they encounter the bug, and I didn't want to serialize twice for every website.
so, now people can pro actively change the values in the database by saving it once and we do not do more than necessary
|
mamhoff
approved these changes
Jun 3, 2024
This was referenced Jun 3, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Currently boolean values of ingredient video and audio are stored as strings ("0"/"1") in the data column JSON.
Cast to Boolean before we save to make this booleans.
Checklist