Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.2-stable] fix Ingredient Audio and Video boolean type casting #2912

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

alchemycms-bot
Copy link
Collaborator

Backport

This will backport the following commits from main to 7.2-stable:

Questions ?

Please refer to the Backport tool documentation

Currently boolean values of ingredient video and audio
are stored as strings ("0"/"1") in the data column JSON.

Cast to Boolean before we save to make this booleans.

(cherry picked from commit 0ec35d5)
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.97%. Comparing base (87205af) to head (2e7a517).

Additional details and impacted files
@@             Coverage Diff             @@
##           7.2-stable    #2912   +/-   ##
===========================================
  Coverage       95.96%   95.97%           
===========================================
  Files             232      232           
  Lines            6273     6279    +6     
===========================================
+ Hits             6020     6026    +6     
  Misses            253      253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit 4805093 into 7.2-stable Jun 4, 2024
33 checks passed
@tvdeyen tvdeyen deleted the backport/7.2-stable/pr-2909 branch June 4, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants