Comprehensive safety, validation, testing, and DX improvements#2
Merged
AndrewAltimit merged 2 commits intomainfrom Feb 21, 2026
Merged
Comprehensive safety, validation, testing, and DX improvements#2AndrewAltimit merged 2 commits intomainfrom
AndrewAltimit merged 2 commits intomainfrom
Conversation
- Replace std::sync::Mutex/RwLock with parking_lot across IPC, daemon, and video player code to eliminate mutex poisoning panics (Phase 1a) - Replace expect() in FFmpeg init with OnceLock error propagation (Phase 1d) - Add Validate trait with NaN/Inf, string length, and data size checks for all protocol message types (Phase 2a) - Add video source URL validation in both daemons (Phase 2b) - Add MAX_FRAME_DIMENSION bounds check in itk-shmem (Phase 2c) - Add 48 new tests: adversarial protocol tests, itk-net coverage, IPC integration tests, and itk-sync edge cases (Phase 3) - Add Justfile, elevate clippy lints to deny, add tracing to core crates, and clean up disabled CI workflows (Phase 4) - Migrate itk-protocol from bincode to bitcode with VERSION bump (Phase 5a) - Add seqlock writer-count runtime check (Phase 5c) - Add daemon health-check ping/pong in launcher (Phase 5d) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collapse nested if/if-let into let-chains (edition 2024) in validate_video_source to satisfy clippy::collapsible_if. Add .githooks/pre-commit that runs fmt, clippy, and tests on core crates before each commit. Install with: git config core.hooksPath .githooks Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
std::sync::Mutex/RwLockwithparking_lotacross IPC, daemon, and video player code to eliminate mutex poisoning panics; replaceexpect()in FFmpeg init with graceful error propagationValidatetrait enforcing NaN/Inf rejection, string length caps (256B), and data size limits (64KB) for all protocol message types; add video source URL allowlisting; add frame dimension bounds in shared memoryJustfilewith common dev recipes, elevate clippy lints (dbg_macro,todo,unimplemented) todeny, add tracing toitk-protocolanditk-shmem, remove 4 disabled AI review jobs from CIitk-protocolserialization frombincodetobitcode(bump protocol VERSION to 2), add seqlock writer-count runtime check, add daemon health-check ping/pong in launcherTest plan
cargo fmt --all -- --checkpassescargo clippy --all-targets -- -D warningspasses (buildable crates)cargo test-- 64 tests pass across 5 core cratescargo deny check-- advisories, bans, licenses, sources all OKGenerated with Claude Code