Skip to content

Comprehensive safety, validation, testing, and DX improvements #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndrewAltimit merged 2 commits into from
Feb 21, 2026
Merged

Comprehensive safety, validation, testing, and DX improvements #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31aa670
Comprehensive safety, validation, testing, and DX improvements
Feb 21, 2026
b442b83
Fix collapsible_if clippy lint and add pre-commit hook
Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions .githooks/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
#!/usr/bin/env bash
# Pre-commit hook for game-mods workspace
# Install: git config core.hooksPath .githooks
#
# Runs the same checks as CI (fmt, clippy, test) on buildable crates.
# Skips crates requiring system libs not available locally (ffmpeg, vulkan).

set -euo pipefail

# Colors (if terminal supports them)
RED='\033[0;31m'
GREEN='\033[0;32m'
YELLOW='\033[0;33m'
NC='\033[0m'

# Crates that can always be built (no system lib deps)
CORE_CRATES=(
itk-shmem
itk-ipc
itk-protocol
itk-sync
itk-net
)

echo -e "${YELLOW}pre-commit: checking formatting...${NC}"
if ! cargo fmt --all -- --check 2>/dev/null; then
echo -e "${RED}FAILED:${NC} cargo fmt --all -- --check"
echo "Run 'cargo fmt --all' to fix."
exit 1
fi
echo -e "${GREEN}OK${NC}"

# Build clippy args: -p crate1 -p crate2 ...
CLIPPY_ARGS=()
for crate in "${CORE_CRATES[@]}"; do
CLIPPY_ARGS+=(-p "$crate")
done

echo -e "${YELLOW}pre-commit: running clippy (core crates)...${NC}"
if ! cargo clippy "${CLIPPY_ARGS[@]}" --all-targets -- -D warnings 2>/dev/null; then
echo -e "${RED}FAILED:${NC} cargo clippy"
exit 1
fi
echo -e "${GREEN}OK${NC}"

echo -e "${YELLOW}pre-commit: running tests (core crates)...${NC}"
if ! cargo test "${CLIPPY_ARGS[@]}" 2>/dev/null; then
echo -e "${RED}FAILED:${NC} cargo test"
exit 1
fi
echo -e "${GREEN}OK${NC}"

echo -e "${GREEN}All pre-commit checks passed.${NC}"
Loading