Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

EndowmentCreated event: add name (string) #379

Merged
merged 3 commits into from
Sep 14, 2023
Merged

EndowmentCreated event: add name (string) #379

merged 3 commits into from
Sep 14, 2023

Conversation

SovereignAndrey
Copy link
Contributor

Explanation of the solution

Adds the endowment name to the EndowmentCreated event data returned from the AccountsCreateEndowment facet's createEndowment endpoint.

Instructions on making this work

  • run yarn or yarn install to install npm dependencies

@SovereignAndrey SovereignAndrey added the enhancement New feature or request label Sep 14, 2023
@SovereignAndrey SovereignAndrey self-assigned this Sep 14, 2023
0xNeshi
0xNeshi suggested changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update relevant tests

@0xNeshi 0xNeshi mentioned this pull request Sep 14, 2023
Merged
SovereignAndrey and others added 2 commits September 14, 2023 13:28
@SovereignAndrey
Update contracts/core/accounts/interfaces/IAccountsEvents.sol
8496eb6 
Co-authored-by: Nenad Misic <nenad@angelprotocol.io>
fix tests
06ceae1
@0xNeshi 0xNeshi merged commit af39b10 into master Sep 14, 2023
1 check passed
@0xNeshi 0xNeshi deleted the endow-name branch September 14, 2023 05:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@0xNeshi 0xNeshi 0xNeshi approved these changes

Assignees

@SovereignAndrey SovereignAndrey

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SovereignAndrey @0xNeshi