Adding better error handling in Go through panic/recovery method with error returns #173
+62
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewmoreno-apryse
force-pushed
the
amoreno/go-error-handling
branch
4 times, most recently
from
8884539 to
1c584ec
Compare
…Director_SignatureHandler
andrewmoreno-apryse
force-pushed
the
amoreno/go-error-handling
branch
from
846116e to
647c20b
Compare
…ing with panic recovery
andrewmoreno-apryse
force-pushed
the
amoreno/go-error-handling
branch
from
ccd20b2 to
8bb0f44
Compare
… see if that fixes the pointer conversion error
…hat fixes the pointer conversion error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a WIP to change how we handle errors in our Go SDK. Previously, we just panicked on every error. However, errors in Go are normally returned in addition to other return types. This PR bridges the gap between C++ exceptions and Go errors using typemaps in SWIG. However, it is a WIP as these typemaps have been causing issues with SWIG's internal functions when applied broadly.