Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/refactor model #278

Closed
wants to merge 13 commits into from
Closed

Feature/refactor model #278

wants to merge 13 commits into from

Conversation

Laxraa
Copy link
Collaborator

@Laxraa Laxraa commented Sep 28, 2023

I removed the ModelProviderAgent and ModelProviderInformant classes. Additionally, I replaced ModelInstance in every class except the Connectors. However, it's my understanding that the Connectors will be removed as well.
The Connectors and their related classes still need to be removed. Furthermore, there may be some issues in my code since my knowledge of the project is limited.
Unfortunately, I wasn't able to fix the following tests in time:

  • TraceLinkEvaluationSadCodeDirectIT (located in tests-tlr)
  • TraceLinkEvaluationSadCodeDirectIT (located in tests-tlr)
  • TraceLinkEvaluationIT (located in tests-tlr)
  • InconsistencyDetectionEvaluationIT (located in tests-inconsistency)

@Gram21
Copy link
Member

Gram21 commented Oct 13, 2023

Thank you very much for your contribution, it helps us a lot. We will (soon) look into it and continue working on it.

@dfuchss
Copy link
Member

dfuchss commented Dec 4, 2023

Resolved by #301

@dfuchss dfuchss closed this Dec 4, 2023
@dfuchss dfuchss deleted the feature/refactor_model branch December 4, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants