Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Replace Legacy Architecture Model #301

Merged
merged 11 commits into from
Dec 4, 2023
Merged

Conversation

dfuchss
Copy link
Member

@dfuchss dfuchss commented Nov 27, 2023

Currently, ArDoCo uses two versions of SAMs. See #278

This PR deprecates one of them and removes the extractors of the old SAM.

@dfuchss dfuchss force-pushed the feature/remove-legacy-sam branch from cbf6df6 to b644cdf Compare November 27, 2023 15:26
@dfuchss dfuchss force-pushed the feature/remove-legacy-sam branch from b644cdf to 91c3f83 Compare November 27, 2023 15:28
@dfuchss dfuchss self-assigned this Nov 27, 2023
@Gram21
Copy link
Member

Gram21 commented Nov 27, 2023

This PR also updates the Java version to 21. Can you then please update the information about the Java version in the wiki (I think) and all places where we mention it? Thanks!

@dfuchss dfuchss force-pushed the feature/remove-legacy-sam branch from 3d70380 to 11ae34e Compare November 27, 2023 16:28
@dfuchss dfuchss force-pushed the feature/remove-legacy-sam branch from 40bc42a to 1e00ae3 Compare November 28, 2023 13:59
@dfuchss dfuchss marked this pull request as ready for review November 28, 2023 14:37
Copy link

sonarqubecloud bot commented Dec 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 46 Code Smells

77.1% 77.1% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@dfuchss dfuchss merged commit 7992f41 into main Dec 4, 2023
8 of 9 checks passed
@dfuchss dfuchss deleted the feature/remove-legacy-sam branch December 4, 2023 13:53
@dfuchss dfuchss mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants