Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TUNIC: Combat logic fix #4589

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

TUNIC: Combat logic fix #4589

wants to merge 19 commits into from
+277 −152

Conversation

ScipioWright
Copy link
Collaborator

@ScipioWright ScipioWright commented Feb 1, 2025 •
edited
Loading

What is this fixing or adding?

Nightmare scenario of like 5 different issues at once. But it works now as far as I can tell.

How was this tested?

Testing a specific test case, new unit test to test for this issue.
Ensured the new unit test can fail without the fix in, and does not fail with the fix in.

@ScipioWright ScipioWright added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Feb 1, 2025
@ScipioWright ScipioWright mentioned this pull request Feb 1, 2025
Closed
@ScipioWright ScipioWright marked this pull request as draft February 2, 2025 03:02
@ScipioWright ScipioWright marked this pull request as ready for review February 2, 2025 19:02
qwint
qwint reviewed Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@qwint qwint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pure code review ran no tests/gens/games/etc.

most of my comments are just optimizations, simplifications, and code readability suggestions that aren't necessary, but I think most of the comments should be addressed (including declined) in some way

worlds/tunic/combat_logic.py Outdated Show resolved Hide resolved
worlds/tunic/test/test_combat.py Outdated Show resolved Hide resolved
worlds/tunic/test/test_combat.py Outdated Show resolved Hide resolved
worlds/tunic/test/test_combat.py Outdated Show resolved Hide resolved
worlds/tunic/test/test_combat.py Outdated Show resolved Hide resolved
worlds/tunic/combat_logic.py Show resolved Hide resolved
worlds/tunic/combat_logic.py Outdated Show resolved Hide resolved
worlds/tunic/combat_logic.py Outdated Show resolved Hide resolved
worlds/tunic/combat_logic.py Outdated Show resolved Hide resolved
worlds/tunic/combat_logic.py Show resolved Hide resolved
qwint
qwint approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@qwint qwint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all my comments addressed
(the context of the approval has not changed)

silent-destroyer
silent-destroyer approved these changes Feb 8, 2025
View reviewed changes
Copy link
Contributor

@silent-destroyer silent-destroyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran hundreds of test gens with no failures; checked the spoiler playthrough for a few of the gens and found no apparent issues

@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwint qwint qwint approved these changes

@silent-destroyer silent-destroyer silent-destroyer approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ScipioWright @qwint @silent-destroyer