Support AutoIncrement.None #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshleighAdams
requested changes
Aug 16, 2024
KingKiller100
force-pushed
the
kingkiller100/autoincrement-none-support
branch
from
1a988ae to
ecaf8c1
Compare
- `NextVersion()` retains guard style logic - Removed unnecessary braces - Added/formatted tests
AshleighAdams
approved these changes
Aug 16, 2024
|
Ready for merge, thanks 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In order to help support returning the last tag recorded without bumping any components, changes to the AutoIncrement enum support were required.
Are there any concerns or areas to be aware of regarding the approach taken or areas changed?
Tests
Added unit test to verify the last recorded tag or min version specified are returned as-is
Tested
-a noneargument being used thru Visual Studio debuggerTests added
Linked issue if exists
Updated Documentation