Remove old pre-production Koha volumes code #1992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Koha, it is possible to create item groups (i.e. volumes) without attaching items to that group. If an item group has no items, the volume level hold will be unfillable unless items are added to it at a future time. For these reasons, it makes sense to filter these empty volumes out. A possible future enhancement would be to make the display of empty volumes configurable. Test Plan: 1) Set up an instance of Koha connected to Aspen Discovery 2) Create 10 items, and four item groups on one record 3) Attach 3 items to each of 3 of the item groups 4) Run koha_export.jar 5) Note the empty volume shows in the list of volumes you can place holds on 6) Check out this branch 7) Recompile koha_export.jar 8) Repeat step 4 8) Note the empty volume is no longer in the volume pulldown Closes Aspen-Discovery#1989
Any libraries using the pre-release version of Koha's item groups ( i.e. volumes ) has since been upgraded past 22.11. This code should be safe to remove now as it relates to a version of a feature that was never part of community Koha. Test Plan: No changes in behavior should be noted Closes Aspen-Discovery#1990
mdnoble73
requested changes
Aug 19, 2024
|
@mdnoble73 done! |
mdnoble73
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any libraries using the pre-release version of Koha's item groups ( i.e. volumes ) has since been upgraded past 22.11.
This code should be safe to remove now as it relates to a version of a feature that was never part of community Koha.