Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old pre-production Koha volumes code #1992

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Remove old pre-production Koha volumes code #1992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca23b7d
Hide empty item groups for volume-level holds
kylemhall Aug 16, 2024
28f93d3
Remove old pre-production Koha volumes code
kylemhall Aug 16, 2024
cbafe03
Update release notes
kylemhall Aug 21, 2024
d72eb08
Merge branch '24.09.00' into issue_1990
mdnoble73 Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions code/koha_export/src/com/turning_leaf_technologies/koha_export/KohaExportMain.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,15 +529,9 @@ private static void exportVolumes(Connection dbConn, Connection kohaConn) {
float kohaVersion = getKohaVersion(kohaConn);
PreparedStatement getVolumeInfoStmt;
PreparedStatement getItemsForVolumeStmt;
if (kohaVersion < 22.11) {
//Arlington's code for volumes
getVolumeInfoStmt = kohaConn.prepareStatement("SELECT * from volumes", ResultSet.TYPE_FORWARD_ONLY, ResultSet.CONCUR_READ_ONLY);
getItemsForVolumeStmt = kohaConn.prepareStatement("SELECT * from volume_items", ResultSet.TYPE_FORWARD_ONLY, ResultSet.CONCUR_READ_ONLY);
}else {
//community code for
getVolumeInfoStmt = kohaConn.prepareStatement("SELECT * from item_groups", ResultSet.TYPE_FORWARD_ONLY, ResultSet.CONCUR_READ_ONLY);
getItemsForVolumeStmt = kohaConn.prepareStatement("SELECT * from item_group_items", ResultSet.TYPE_FORWARD_ONLY, ResultSet.CONCUR_READ_ONLY);
}
// Filter out any item groups that do not currently contain items
getVolumeInfoStmt = kohaConn.prepareStatement("SELECT item_groups.* FROM item_groups LEFT JOIN item_group_items USING (item_group_id) GROUP BY item_group_id HAVING COUNT(item_id) > 0", ResultSet.TYPE_FORWARD_ONLY, ResultSet.CONCUR_READ_ONLY);
getItemsForVolumeStmt = kohaConn.prepareStatement("SELECT * from item_group_items", ResultSet.TYPE_FORWARD_ONLY, ResultSet.CONCUR_READ_ONLY);
PreparedStatement addVolumeStmt = dbConn.prepareStatement("INSERT INTO ils_volume_info (recordId, volumeId, displayLabel, relatedItems, displayOrder) VALUES (?,?,?,?, ?) ON DUPLICATE KEY update recordId = VALUES(recordId), displayLabel = VALUES(displayLabel), relatedItems = VALUES(relatedItems), displayOrder = VALUES(displayOrder)");
PreparedStatement deleteVolumeStmt = dbConn.prepareStatement("DELETE from ils_volume_info where volumeId = ?");

Expand Down
2 changes: 2 additions & 0 deletions code/web/release_notes/24.09.00.MD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@
- Improve docker image build time and add support for GHCR
### Koha Driver Updates
- Remove superfluous loop in Koha driver function updateHomeLibrary #1968
- Remove old pre-production Koha volumes code
### GitHub Actions
- Add GitHub Actions to check pull requests for release notes

Expand Down Expand Up @@ -153,3 +154,4 @@

- Theke Solutions
- Lucas Montoya (LM)

Loading