DIS-147 Fix volumeId check for the items without valid item group while placing volume holds #2187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In code/web/Drivers/Koha.php, modified the conditional check for $volumeId to use !empty($volumeId) instead of $volumeId != 0. This ensures that when volumeId is undefined, the check can work successfully and remove the "item_group_id" in $postParams. In this case, the items can be placed successfully even without a valid volume Id.
Use-Case:
Before PR:
Placing a hold on a volume with a valid item group worked correctly.
Placing a hold without selecting a specific volume caused a server error.
After PR: Both holds (with and without selecting a specific volume) are placed successfully without errors.