Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIS-147 Fix volumeId check for the items without valid item group while placing volume holds #2187

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

LiYanjun19
Copy link
Contributor

In code/web/Drivers/Koha.php, modified the conditional check for $volumeId to use !empty($volumeId) instead of $volumeId != 0. This ensures that when volumeId is undefined, the check can work successfully and remove the "item_group_id" in $postParams. In this case, the items can be placed successfully even without a valid volume Id.

Use-Case:

Before PR:
Placing a hold on a volume with a valid item group worked correctly.
Placing a hold without selecting a specific volume caused a server error.
After PR: Both holds (with and without selecting a specific volume) are placed successfully without errors.

@LiYanjun19
Copy link
Contributor Author

@mdnoble73 Thank you, I resubmitted one against 25.01.00

@mdnoble73 mdnoble73 merged commit c2c5466 into Aspen-Discovery:25.01.00 Jan 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants