Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIS-147 Fix volumeId check for the items without valid item group while placing volume holds #2187

Merged
merged 2 commits into from
Jan 2, 2025
Merged

DIS-147 Fix volumeId check for the items without valid item group while placing volume holds #2187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12a8110
DIS-147:Fix volumeId check for the items without valid item group
LiYanjun19 Dec 31, 2024
d13ec1e
Update 25.01.00.MD
LiYanjun19 Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/web/Drivers/Koha.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1938,7 +1938,7 @@ public function placeVolumeHold(User $patron, $recordId, $volumeId, $pickupBranc
} else {
$apiUrl = $this->getWebServiceUrl() . "/api/v1/holds";
if ($this->getKohaVersion() >= 22.11) {
if ($volumeId != 0){
if (!empty($volumeId)){
$postParams = [
'patron_id' => $patron->unique_ils_id,
'pickup_library_id' => $pickupBranch,
Expand Down
3 changes: 3 additions & 0 deletions code/web/release_notes/25.01.00.MD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,9 @@ For records found in an Articles and Database search through the EBSCO host or E
### Boundless/Axis360 Updates
- Update Boundless/Axis360 get records availability API URL and adjusted response processing (DIS-162) (*YL*)

### Koha Updates
- Fix volumeId check for the items without valid item group when placing volume holds (DIS-147) (*YL*)

//lukeg
### Authentication Updates
- Fix typo in Authentication/DatabaseAuthentication.php (DIS-159) (*LG*)
Expand Down
Loading