Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIS-224: Change backup cron job to use mydumper #2196

Open
wants to merge 1 commit into
base: 25.02.00
Choose a base branch
from

Conversation

kylemhall
Copy link
Member

This commit changs the default backup script to use mydumper.

Test Plan:

  1. Set up a new instance of Aspen using createSite.php 2) Note the cron file uses myDumper for backups now!

This commit changs the default backup script to use mydumper.

Test Plan:
1) Set up a new instance of Aspen using createSite.php
2) Note the cron file uses myDumper for backups now!
@@ -38,7 +38,7 @@
# MySQL Nightly Dump #
######################
# backup important bits at 12:10am daily
10 0 * * * root php /usr/local/aspen-discovery/code/web/cron/backupAspen.php {sitename}
10 0 * * * root rm /data/aspen-discovery/{sitename}/sql_backup/mydumper/* && php /usr/local/aspen-discovery/code/web/cron/backupAspen-mydumper.php {sitename}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mydumper is not installed by default so this won't work on a clean server. The pattern is also to clean up old files within the backup script itself rather than cron. We also should preserve 2 backups on a server. This seems to remove all backups.

@@ -69,6 +69,10 @@

// kyle

### Cron Updates
- When loading patron types and libraries from Polaris, automatically associate them with the correct account profile. (DIS-214) (*MDN*)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this has extra information in it from another update. Please don't duplicate the extra release note entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants