-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DIS-224: Change backup cron job to use mydumper #2196
Open
kylemhall
wants to merge
1
commit into
Aspen-Discovery:25.02.00
Choose a base branch
from
kylemhall:DIS-224
base: 25.02.00
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
DIS-224: Change backup cron job to use mydumper
This commit changs the default backup script to use mydumper. Test Plan: 1) Set up a new instance of Aspen using createSite.php 2) Note the cron file uses myDumper for backups now!
commit 04e80dd2c6d637a9b68a1e7742b7f50d6d5243ab
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,7 +38,7 @@ | |
# MySQL Nightly Dump # | ||
###################### | ||
# backup important bits at 12:10am daily | ||
10 0 * * * root php /usr/local/aspen-discovery/code/web/cron/backupAspen.php {sitename} | ||
10 0 * * * root rm /data/aspen-discovery/{sitename}/sql_backup/mydumper/* && php /usr/local/aspen-discovery/code/web/cron/backupAspen-mydumper.php {sitename} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Mydumper is not installed by default so this won't work on a clean server. The pattern is also to clean up old files within the backup script itself rather than cron. We also should preserve 2 backups on a server. This seems to remove all backups. |
||
|
||
############################################# | ||
# New York Times Best seller Lists Updating # | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this has extra information in it from another update. Please don't duplicate the extra release note entry.