Skip to content

Conversation

sankalps0549
Copy link
Collaborator

@sankalps0549 sankalps0549 commented Sep 17, 2025

Description

  • Fixed the check_spdx.py script to fail the CI if the headers are missing.
  • Made CI jobs parallel:
    • static-checks - check_localization, check_spdx
    • test - build, lint, test, coverage
    • build-docs
  • Fixed linting for both script files

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the documentation accordingly
  • I have added a note to CHANGELOG.md describing my changes
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Testing

N/A

Additional Notes

N/A

@sankalps0549 sankalps0549 self-assigned this Sep 17, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the check_spdx script to simplify its functionality by removing the ability to automatically add SPDX headers to files, making it a check-only tool.

  • Removes the add_spdx_header() function and associated automatic header addition functionality
  • Removes command-line argument parsing for the --check-only flag
  • Simplifies the main function to only check for SPDX headers without modification capabilities

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/moldflow/boundary_conditions.py Removes SPDX header from the file
scripts/check_spdx.py Removes automatic SPDX header addition functionality, making it check-only

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sankalps0549 sankalps0549 changed the title check_spdx Script Fix Check Scripts Fixes Sep 17, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

sankalps0549 and others added 2 commits September 17, 2025 11:56
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant