-
Notifications
You must be signed in to change notification settings - Fork 1
Check Scripts Fixes #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modifies the check_spdx script to simplify its functionality by removing the ability to automatically add SPDX headers to files, making it a check-only tool.
- Removes the
add_spdx_header()
function and associated automatic header addition functionality - Removes command-line argument parsing for the
--check-only
flag - Simplifies the main function to only check for SPDX headers without modification capabilities
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
src/moldflow/boundary_conditions.py | Removes SPDX header from the file |
scripts/check_spdx.py | Removes automatic SPDX header addition functionality, making it check-only |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Description
check_spdx.py
script to fail the CI if the headers are missing.Type of change
Please delete options that are not relevant.
Checklist
Please delete options that are not relevant.
Testing
N/A
Additional Notes
N/A