Skip to content

Check Scripts Fixes #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Check Scripts Fixes #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9e76f81
check_spdx script fix
sankalps0549 Sep 17, 2025
3098ad5
Update ci
sankalps0549 Sep 17, 2025
f2b35ea
Checking positive
sankalps0549 Sep 17, 2025
126de6c
Checking new CI
sankalps0549 Sep 17, 2025
73d638d
import fix
sankalps0549 Sep 17, 2025
64b3bb1
lint fix for scripts
sankalps0549 Sep 17, 2025
c9ca4fa
Apply suggestions from code review
sankalps0549 Sep 17, 2025
724fdd9
lint fix
sankalps0549 Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,29 @@ on:
types: [ published ]

jobs:
# Static checks that don't require building
static-checks:
runs-on: windows-2022
steps:
- uses: actions/checkout@v5

- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.13'

- name: Install dependencies
run: |
python -m pip install --upgrade pip
python -m pip install -r requirements.txt

- name: SPDX headers check
run: python scripts/check_spdx.py

- name: Localization check
run: python scripts/check_localization.py --check-only --path src/moldflow --locale-path src/moldflow/locale

# Build and test matrix
test:
runs-on: ${{ matrix.os }}
strategy:
Expand All @@ -27,12 +50,6 @@ jobs:
python -m pip install --upgrade pip
python -m pip install -r requirements.txt

- name: SPDX headers check (check-only)
run: python scripts/check_spdx.py --check-only

- name: Localization check
run: python scripts/check_localization.py --check-only --path src/moldflow --locale-path src/moldflow/locale

- name: Build package
run: python run.py build --install

Expand All @@ -47,7 +64,6 @@ jobs:

build-docs:
runs-on: windows-2022
needs: test

steps:
- uses: actions/checkout@v5
Expand Down
3 changes: 2 additions & 1 deletion run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@
DOCS_BUILD_DIR = os.path.join(DOCS_DIR, 'build')
COVERAGE_HTML_DIR = os.path.join(ROOT_DIR, 'htmlcov')
DIST_DIR = os.path.join(ROOT_DIR, 'dist')
SCRIPTS_DIR = os.path.join(ROOT_DIR, 'scripts')

# Files
PYLINT_CONFIG_FILE = os.path.join(ROOT_DIR, '.pylint.toml')
Expand All @@ -96,7 +97,7 @@
COVERAGE_XML_FILE_NAME = 'coverage.xml'
VERSION_FILE = os.path.join(ROOT_DIR, VERSION_JSON)
DIST_FILES = os.path.join(ROOT_DIR, 'dist', '*')
PYTHON_FILES = [MOLDFLOW_DIR, DOCS_SOURCE_DIR, TEST_DIR, "run.py"]
PYTHON_FILES = [MOLDFLOW_DIR, DOCS_SOURCE_DIR, TEST_DIR, "run.py", SCRIPTS_DIR]


def run_command(args, cwd=os.getcwd(), extra_env=None):
Expand Down
Loading