-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader Onboarding: Do not render if user registered before Oct 1 2024 #95624
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~73 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
…arding will render
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as advertised !
Related to https://github.com/Automattic/loop/issues/197
Proposed Changes
ReaderOnboarding
componentReaderOnboarding
calledonRender
that alerts the parent component if theReaderOnboarding
component will render.onRender
prop state, we can conditionally show theFollowingIntro
component on /readWhy are these changes being made?
onRender
state property allows us to keep the "gatekeeping" logic inside theReaderOnboarding
component so the parent component doesn't need to know the rules for displaying the component. That will allow us to easily reuse theReaderOnboarding
component in other places without duplicating the display rules everywhere it is used.Testing Instructions
Pre-merge Checklist