Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Further fix flaky Twitter test #95672

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Oct 24, 2024

Proposed Changes

PR #95579 attempted to adjust the test to accept both the expected iframe and the fallback link produced when Twitter's API is flaky. Unfortunately the way Playwright interpreted the code is like iframe > ( tweet or link ) rather than ( iframe > tweet ) or link as intended, so it's still not finding the link.

Fall back to using Promise.any() to combine the two locators instead, like we do in a bunch of other places.

Why are these changes being made?

E2E test is still flaky.

Testing Instructions

  • Make sure it works normally, when the tweet is rendered.
  • To force the fallback link to test that case, you can edit wp-includes/class-wp-oembed.php to add something like this at the top of private function _fetch_with_format()
    if ( str_contains( $provider_url_with_args, 'twitter' ) ) return false;

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

PR #95579 attempted to adjust the test to accept both the expected
iframe and the fallback link produced when Twitter's API is flaky.
Unfortunately the way Playwright interpreted the code is like
`iframe > ( tweet or link )` rather than `( iframe > tweet ) or link` as
intended, so it's still not finding the link.

Fall back to using `Promise.any()` to combine the two locators instead,
like we do in a bunch of other places.
@anomiex anomiex added [Type] Bug [Pri] Normal [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 24, 2024
@anomiex anomiex requested a review from a team October 24, 2024 14:23
@anomiex anomiex self-assigned this Oct 24, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@tbradsha tbradsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me.

@anomiex anomiex merged commit aeb8409 into trunk Oct 24, 2024
14 of 15 checks passed
@anomiex anomiex deleted the fix/e2e-flaky-twitter-attempt-2 branch October 24, 2024 14:39
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants