e2e: Further fix flaky Twitter test #95672
Merged
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
PR #95579 attempted to adjust the test to accept both the expected iframe and the fallback link produced when Twitter's API is flaky. Unfortunately the way Playwright interpreted the code is like
iframe > ( tweet or link )
rather than( iframe > tweet ) or link
as intended, so it's still not finding the link.Fall back to using
Promise.any()
to combine the two locators instead, like we do in a bunch of other places.Why are these changes being made?
E2E test is still flaky.
Testing Instructions
wp-includes/class-wp-oembed.php
to add something like this at the top ofprivate function _fetch_with_format()
Pre-merge Checklist