Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Further fix flaky Twitter test #95672

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Commits on Oct 24, 2024

  1. e2e: Further fix flaky Twitter test

    PR #95579 attempted to adjust the test to accept both the expected
    iframe and the fallback link produced when Twitter's API is flaky.
    Unfortunately the way Playwright interpreted the code is like
    `iframe > ( tweet or link )` rather than `( iframe > tweet ) or link` as
    intended, so it's still not finding the link.
    
    Fall back to using `Promise.any()` to combine the two locators instead,
    like we do in a bunch of other places.
    anomiex committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    fa851d5 View commit details
    Browse the repository at this point in the history