Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to change isVideoMirrored option for front camera #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow to change isVideoMirrored option for front camera #120

wants to merge 1 commit into from

Conversation

buubui
Copy link

@buubui buubui commented Oct 4, 2017

Thanks for your framework. I would like to expose the isVideoMirrored property for the front camera in this pull request.

nellthu
nellthu approved these changes Aug 27, 2018
View reviewed changes
Copy link
Contributor

@nellthu nellthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite important commit. Mirroring while in landscape flips the video upside down!

@jonandersen
Copy link
Collaborator

@buubui can you update your fork with the latest changes? After doing so we can merge this into master

@luvacu luvacu mentioned this pull request Jun 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nellthu nellthu nellthu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@buubui @jonandersen @nellthu