Skip to content

fix: avoid span OOB in compute_logderivative_inverse for debug builds #22313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AztecBot wants to merge 1 commit into
base: merge-train/barretenberg
Choose a base branch
from
+11 −5
Draft

fix: avoid span OOB in compute_logderivative_inverse for debug builds #22313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions barretenberg/cpp/src/barretenberg/honk/proof_system/logderivative_library.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,17 @@ void compute_logderivative_inverse(Polynomials& polynomials, auto& relation_para
});
inverse_polynomial.at(i) = denominator;
}
FF* ffstart = &inverse_polynomial.coeffs()[start];
std::span<FF> to_invert(ffstart, end - start);
// Compute inverse polynomial I in place by inverting the product at each row
// Note: zeroes are ignored as they are not used anyway
FF::batch_invert(to_invert);
// Clamp to the polynomial's actual (non-virtual) data range; virtual zero elements need no inversion.
const size_t actual_size = inverse_polynomial.size();
const size_t clamped_start = std::min(start, actual_size);
const size_t clamped_end = std::min(end, actual_size);
if (clamped_start < clamped_end) {
FF* ffstart = &inverse_polynomial.coeffs()[clamped_start];
std::span<FF> to_invert(ffstart, clamped_end - clamped_start);
// Compute inverse polynomial I in place by inverting the product at each row
// Note: zeroes are ignored as they are not used anyway
FF::batch_invert(to_invert);
}
};
if constexpr (UseMultithreading) {
parallel_for([&](const ThreadChunk& chunk) {
Expand Down
Loading