refactor: add partial note support for value note

[sklppy88]

We are simply adding partial note support for value note.

We do it by simply porting the logic from tokennote to value note and adapting what needs to be adapted.

Resolves #8105.

[sklppy88]

• refactor: replace token note with uint note #8143
• refactor: add uint (U128) note to aztec-nr and remove OwnedNote from ValueNote #8142
• refactor: add partial note support for value note #8141 👈
• refactor: rework balances map #8127
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sklppy88 and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• avm_simulation_time_ms (Token:mint_public): 71.1 (+65%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 41.3 (-37%)
• avm_simulation_time_ms (Token:transfer_public): 37.9 (+73%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,755	1,578 (+1%)	711	759 (-2%)	771 (-1%)
proof_construction_time_sha256_30_ms	11,455	3,080	1,372 (-1%)	1,411 (-1%)	1,466
proof_construction_time_sha256_100_ms	43,998	11,777	5,441 (-2%)	5,454	5,696
proof_construction_time_poseidon_hash_ms	79.0 (+1%)	34.0	34.0	58.0	88.0
proof_construction_time_poseidon_hash_30_ms	1,528	421	202	229 (-5%)	266 (-2%)
proof_construction_time_poseidon_hash_100_ms	5,641	1,510	680 (+1%)	723 (-1%)	749

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,356	7,876	14,884
l1_rollup_calldata_gas	50,256	93,018	178,276
l1_rollup_execution_gas	842,916	1,576,574	3,361,888
l2_block_processing_time_in_ms	245 (-2%)	453 (+1%)	803 (-2%)
l2_block_building_time_in_ms	11,287	22,161	44,406
l2_block_rollup_simulation_time_in_ms	11,286	22,160	44,406
l2_block_public_tx_process_time_in_ms	9,554	20,344 (-1%)	42,576 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,005	3,927 (+1%)
node_database_size_in_bytes	12,652,624	16,691,280
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	98.6 (+4%)	397 (-1%)	21,735	44,860	N/A
private-kernel-inner	175 (-15%)	703 (+1%)	72,544	45,007	N/A
private-kernel-reset-tiny	314 (+1%)	714 (+2%)	65,593	44,846	N/A
private-kernel-tail	166 (-1%)	135 (-3%)	50,644	52,257	N/A
base-parity	5.62 (+2%)	N/A	160	96.0	N/A
root-parity	35.4 (-1%)	N/A	73,948	96.0	N/A
base-rollup	3,438	N/A	189,136	664	N/A
block-root-rollup	41.2	N/A	58,205	2,448	N/A
public-kernel-setup	85.3 (+1%)	N/A	105,085	71,222	N/A
public-kernel-app-logic	96.7	N/A	104,911	71,222	N/A
public-kernel-tail	856	N/A	390,582	16,414	N/A
private-kernel-reset-small	311 (-3%)	N/A	66,341	45,629	N/A
private-kernel-tail-to-public	672 (-12%)	613 (-1%)	455,400	1,825	N/A
public-kernel-teardown	83.7	N/A	105,349	71,222	N/A
merge-rollup	20.2	N/A	38,174	664	N/A
undefined	N/A	N/A	N/A	N/A	78,092 (-7%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	344
ContractInstanceDeployer:deploy	1,408	11,731	18.2 (+1%)
MultiCallEntrypoint:entrypoint	1,920	11,731	406
FeeJuice:deploy	1,376	11,731	394 (+2%)
SchnorrAccount:constructor	1,312	11,731	73.7
SchnorrAccount:entrypoint	2,304	11,731	393 (+1%)
Token:privately_mint_private_note	1,280	11,731	107 (+8%)
FPC:fee_entrypoint_public	1,344	11,731	27.6 (+5%)
Token:transfer	1,312	11,731	224
Benchmarking:create_note	1,344	11,731	87.5 (+3%)
SchnorrAccount:verify_private_authwit	1,280	11,731	30.9 (+10%)
Token:unshield	1,376	11,731	524 (-2%)
FPC:fee_entrypoint_private	1,376	11,731	688 (-2%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	60.7	7,101
FeeJuice:set_portal	12.2 (-4%)	2,128
Token:constructor	83.8	25,285
FPC:constructor	55.2 (-2%)	17,853
FeeJuice:mint_public	39.4 (+2%)	5,415
Token:mint_public	⚠️ 71.1 (+65%)	10,101
Token:assert_minter_and_mint	⚠️ 41.3 (-37%)	6,844
AuthRegistry:set_authorized	45.9 (+10%)	3,969
FPC:prepare_fee	233 (+2%)	6,747
Token:transfer_public	⚠️ 37.9 (+73%)	38,126
FPC:pay_refund	60.0 (+22%)	9,398
Benchmarking:increment_balance	1,195	6,179
Token:_increase_public_balance	41.8	7,705
FPC:pay_refund_with_shielded_rebate	63.6 (-2%)	9,881

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.167 (+2%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.19 (+1%)	3.86 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.114 (+1%)	0.109 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.5 (+2%)	17.6 (-1%)	30.1 (-1%)	59.7 (+1%)	111 (-1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.110 (+3%)	0.102 (-1%)	0.0983	0.103 (+2%)	0.0999
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.3 (+2%)	25.6 (+1%)	42.8 (-1%)	83.0 (+2%)	159 (-2%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.109 (+2%)	0.103 (+1%)	0.0999 (-5%)	0.103 (+1%)	0.100 (-3%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.7 (+2%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.107 (+1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,779	668,997

Transaction size based on fee payment method

| Metric | |
| - | |

[sklppy88]

I implement this to keep parity with tokennote.

[nventuro]

It's fine to have this as a temporary standin as the thing gets replaced, but ultimately this trait is unecessary and we should remove it eventually.

[nventuro]

It's fine to have this as a temporary standin as the thing gets replaced, but ultimately this trait is unecessary and we should remove it eventually.