-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace token note with uint note #8143
refactor: replace token note with uint note #8143
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
265802c
to
353b842
Compare
230064a
to
19b345e
Compare
a8e830b
to
8dce58f
Compare
Benchmark resultsMetrics with a significant change:
Detailed resultsAll benchmarks are run on txs on the This benchmark source data is available in JSON format on S3 here. Proof generationEach column represents the number of threads used in proof generation.
L2 block published to L1Each column represents the number of txs on an L2 block published to L1.
L2 chain processingEach column represents the number of blocks on the L2 chain where each block has 8 txs.
Circuits statsStats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.
Stats on running time collected for app circuits
AVM SimulationTime to simulate various public functions in the AVM.
Public DB AccessTime to access various public DBs.
Tree insertion statsThe duration to insert a fixed batch of leaves into each tree type.
MiscellaneousTransaction sizes based on how many contract classes are registered in the tx.
Transaction size based on fee payment method | Metric | | |
353b842
to
c5ba475
Compare
8dce58f
to
ebc0127
Compare
c5ba475
to
ccd8079
Compare
ebc0127
to
8c392e3
Compare
noir-projects/noir-contracts/contracts/token_contract/src/main.nr
Outdated
Show resolved
Hide resolved
ccd8079
to
583b872
Compare
8c392e3
to
ed35a2b
Compare
583b872
to
4e1422e
Compare
ed35a2b
to
5e921f4
Compare
4e1422e
to
44e0527
Compare
368acf0
to
ae20529
Compare
70259b8
to
f083f74
Compare
ae20529
to
c92bc4d
Compare
3cdff8a
to
3f0eb35
Compare
cccd835
to
26e7db5
Compare
3f0eb35
to
a244a4a
Compare
d5dbcb1
to
2e3b28f
Compare
dc958a2
to
d3fb39d
Compare
2e3b28f
to
9d889cc
Compare
159f51e
to
a2ea86a
Compare
a2ea86a
to
c7a7210
Compare
cb92053
to
ff52a55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic thank you!
@@ -146,7 +146,7 @@ export class TokenContract extends ContractBase { | |||
}, | |||
balances: { | |||
slot: new Fr(3n), | |||
typ: 'BalancesMap<TokenNote>', | |||
typ: 'BalancesMap<UintNote>', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typ: 'BalancesMap<UintNote>', | |
typ: 'BalancesMap', |
Quite fragile that this exists in an md
file regardless
ff52a55
to
34e1f34
Compare
34e1f34
to
b42f95b
Compare
b42f95b
to
1540c8e
Compare
In this PR, we are replacing the token note with our previously added U128 note and making BalanceSet hold a UintNote instead of being generic. The token note is now redundant as we have a UintNote in aztec nr now.
Resolves #8107.