fix: Remove default security contact email and correct TLS assignment

[oZakari]

Overview/Summary

This pull request includes several updates to the Azure policy assignments and related documentation. The changes primarily focus on updating policy definitions, modifying default parameter values, and updating documentation to reflect these changes.

Policy Definition Updates:

• Updated the definitionId for the Enforce-EncryptTransit policy to a new version in alzDefaultPolicyAssignments.bicep and policy_assignment_es_enforce_tls_ssl.tmpl.json. [1] [2]

Parameter Value Modifications:

• Changed the default value of parMsDefenderForCloudEmailSecurityContact to an empty string in multiple files to remove the placeholder email. [1] [2] [3]

Documentation Updates:

• Updated the documentation to reflect the change in parMsDefenderForCloudEmailSecurityContact parameter from No to Yes to indicate it is now required.
• Updated the example value for parMsDefenderForCloudEmailSecurityContact to an empty string in the generated documentation.

Related Issues/Work Items

Closes #969

This PR fixes/adds/changes/removes

1. Replaced outdated TLS policy set definition in applicable assignment
2. Remove default value for Security Contact email parameter and make it a required field as per request of SLZ team

Breaking Changes

None. Although the default parameter for the Security Contact email address parameter is removed, it does 't break an existing deployment.

Testing Evidence

Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

• Read the Contribution Guide and ensured this PR is compliant with the guide
• Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
• Checked for duplicate Pull Requests
• Associated it with relevant GitHub Issues
• (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
• Ensured my code/branch is up-to-date with the latest changes in the main branch
• Performed testing and provided evidence.
• Updated one or more of the following tests (if required)
  • Unit
  • Linting
  • E2E (End-To-End)
  • ValidateAzCloud (Base validation in Azure Cloud)
  • ValidateMcCloud (Base validation in Azure China Cloud)
• Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
• If relevant, created or updated Code Tours here

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[oZakari]

/azp run validateazcloud

PR Overview

This pull request updates Azure policy assignments and corresponding documentation to remove the default security contact email and update the TLS policy definition. Key changes include:

• Updating the definitionId for the Enforce-EncryptTransit policy.
• Removing the default value for the parMsDefenderForCloudEmailSecurityContact parameter.
• Adjusting documentation to reflect that a security contact email is now required.

Reviewed Changes

File	Description
infra-as-code/bicep/modules/policy/assignments/alzDefaults/generateddocs/alzDefaultPolicyAssignments.bicep.md	Removed the placeholder default email value and updated the documentation to align with the new required parameter state

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

infra-as-code/bicep/modules/policy/assignments/alzDefaults/generateddocs/alzDefaultPolicyAssignments.bicep.md:303

• [nitpick] The generated documentation does not explicitly indicate that the parMsDefenderForCloudEmailSecurityContact parameter is now required. Consider adding a note in the parameter description to clarify that a valid email must be provided.

"parMsDefenderForCloudEmailSecurityContact": {

[azure-pipelines]

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

[oZakari]

/azp run valideazcloud

[azure-pipelines]

No pipelines are associated with this pull request.

[oZakari]

/azp run validateazcloud

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).