Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove default security contact email and correct TLS assignment #971

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Remove default security contact email and correct TLS assignment #971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2820fb
Remove default email and correct TLS assignment
oZakari Feb 28, 2025
d48efad
Generate Parameter Markdowns [oZakari/0e062f68]
github-actions[bot] Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions infra-as-code/bicep/modules/policy/assignments/alzDefaults/alzDefaultPolicyAssignments.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ param parLogAnalyticsWorkspaceLogRetentionInDays string = '365'
param parAutomationAccountName string = 'alz-automation-account'

@description('Email address for Microsoft Defender for Cloud alerts.')
param parMsDefenderForCloudEmailSecurityContact string = 'security_contact@replace_me.com'
param parMsDefenderForCloudEmailSecurityContact string = ''

@description('Enable/disable DDoS Network Protection.')
param parDdosEnabled bool = true
Expand Down Expand Up @@ -480,7 +480,7 @@ var varPolicyAssignmentEnforceGRKeyVault = {
}

var varPolicyAssignmentEnforceTLSSSL = {
definitionId: '${varTopLevelManagementGroupResourceId}/providers/Microsoft.Authorization/policySetDefinitions/Enforce-EncryptTransit_20240509'
definitionId: '${varTopLevelManagementGroupResourceId}/providers/Microsoft.Authorization/policySetDefinitions/Enforce-EncryptTransit_20241211'
libDefinition: loadJsonContent('../../../policy/assignments/lib/policy_assignments/policy_assignment_es_enforce_tls_ssl.tmpl.json')
}

Expand Down
4 changes: 1 addition & 3 deletions ...licy/assignments/alzDefaults/generateddocs/alzDefaultPolicyAssignments.bicep.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,6 @@ Name of the Automation Account.

Email address for Microsoft Defender for Cloud alerts.

- Default value: `security_contact@replace_me.com`

### parDdosEnabled

![Parameter Setting](https://img.shields.io/badge/parameter-optional-green?style=flat-square)
Expand Down Expand Up @@ -303,7 +301,7 @@ Opt out of deployment telemetry.
"value": "alz-automation-account"
},
"parMsDefenderForCloudEmailSecurityContact": {
"value": "security_contact@replace_me.com"
"value": ""
},
"parDdosEnabled": {
"value": true
Expand Down
2 changes: 1 addition & 1 deletion ...policy/assignments/alzDefaults/parameters/alzDefaultPolicyAssignments.parameters.min.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"value": "alz-automation-account"
},
"parMsDefenderForCloudEmailSecurityContact": {
"value": "security_contact@replace_me.com"
"value": ""
},
"parPrivateDnsZonesLocation": {
"value": "eastus"
Expand Down
2 changes: 1 addition & 1 deletion ...licy/assignments/lib/policy_assignments/policy_assignment_es_deploy_mdfc_config.tmpl.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"notScopes": [],
"parameters": {
"emailSecurityContact": {
"value": "security_contact@replace_me"
"value": ""
},
"logAnalytics": {
"value": "law-alz"
Expand Down
4 changes: 2 additions & 2 deletions .../policy/assignments/lib/policy_assignments/policy_assignment_es_enforce_tls_ssl.tmpl.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{
"name": "Enforce-TLS-SSL-H224",
"name": "Enforce-TLS-SSL-Q225",
"type": "Microsoft.Authorization/policyAssignments",
"apiVersion": "2024-04-01",
"properties": {
"description": "Choose either Deploy if not exist and append in combination with audit or Select Deny in the Policy effect. Deny polices shift left. Deploy if not exist and append enforce but can be changed, and because missing exsistense condition require then the combination of Audit.",
"displayName": "Deny or Deploy and append TLS requirements and SSL enforcement on resources without Encryption in transit",
"notScopes": [],
"parameters": {},
"policyDefinitionId": "${varTopLevelManagementGroupResourceId}/providers/Microsoft.Authorization/policySetDefinitions/Enforce-EncryptTransit_20240509",
"policyDefinitionId": "${varTopLevelManagementGroupResourceId}/providers/Microsoft.Authorization/policySetDefinitions/Enforce-EncryptTransit_20241211",
"scope": null,
"enforcementMode": "Default"
},
Expand Down
Loading