Add env variable to warn customers #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoyowang268
approved these changes
Jan 22, 2024
|
Image size with this change is base: 5810MB, tools: 8442MB. |
evelyn-ys
approved these changes
Jan 23, 2024
evelyn-ys
reviewed
Jan 24, 2024
jiasli
reviewed
Jan 24, 2024
linux/tools.Dockerfile
Outdated
| @@ -71,5 +71,7 @@ RUN ln -s /usr/bin/node /usr/bin/nodejs | |||
| # Add dotnet tools to PATH so users can install a tool using dotnet tools and can execute that command from any directory | |||
| ENV PATH ~/.local/bin:~/bin:~/.dotnet/tools:$PATH | |||
|
|
|||
| ENV AZURE_CORE_SHOW_SECRETS_WARNING True | |||
There was a problem hiding this comment.
AZURE_CORE_SHOW_SECRETS_WARNING is Azure CLI specific, mapped from az config set core.show_secrets_warning.
As shown in Azure/azure-cli#10241, there are already some common environment variables, such as AZURE_TENANT_ID, AZURE_CLIENT_ID, AZURE_CLIENT_SECRET, AZURE_SUBSCRIPTION_ID.
If Azure CLI and Azure PowerShell want to share the same env var, it's better to create a common env var such as AZURE_SHOW_SECRETS_WARNING.
Co-authored-by: Yishi Wang <yishiwang@microsoft.com>
|
Image size with this change is base: 5818MB, tools: 8464MB. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show warning to customer if secret will get revealed. This is for the Az CLI and Az Powershell commands.