Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env variable to warn customers #374

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Add env variable to warn customers #374

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4de26a
Update tools.Dockerfile
darrentu Jan 22, 2024
2495478
Update linux/tools.Dockerfile
darrentu Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions linux/tools.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,5 +71,7 @@ RUN ln -s /usr/bin/node /usr/bin/nodejs
# Add dotnet tools to PATH so users can install a tool using dotnet tools and can execute that command from any directory
ENV PATH ~/.local/bin:~/bin:~/.dotnet/tools:$PATH

ENV AZURE_CORE_SHOW_SECRETS_WARNING True
darrentu marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AZURE_CORE_SHOW_SECRETS_WARNING is Azure CLI specific, mapped from az config set core.show_secrets_warning.

As shown in Azure/azure-cli#10241, there are already some common environment variables, such as AZURE_TENANT_ID, AZURE_CLIENT_ID, AZURE_CLIENT_SECRET, AZURE_SUBSCRIPTION_ID.

If Azure CLI and Azure PowerShell want to share the same env var, it's better to create a common env var such as AZURE_SHOW_SECRETS_WARNING.


# Set AZUREPS_HOST_ENVIRONMENT
ENV AZUREPS_HOST_ENVIRONMENT cloud-shell/1.0
Loading