{packaging} Bump semver to 3.0.x #26523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many Linux distributions, including Fedora, have updated to semver 3.0.0. It would be helpful if azure-cli could use this newer version. Signed-off-by: Major Hayden <major@redhat.com>
️✔️AzureCLI-FullTest
|
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
ghost
added
the
customer-reported
|
Thank you for your contribution major! We will review the pull request and get back to you soon. |
|
packaging |
ghost
requested review from
jiasli
approved these changes
May 25, 2023
jiasli
reviewed
May 25, 2023
| @@ -129,7 +129,7 @@ python-dateutil==2.8.0 | |||
| requests-oauthlib==1.2.0 | |||
| requests[socks]==2.26.0 | |||
| scp==0.13.2 | |||
| semver==2.13.0 | |||
| semver==3.0.0 | |||
There was a problem hiding this comment.
The dependency on semver was introduced by #16857. I have left a comment at #16857 (comment).
3 tasks
bebound
approved these changes
Jun 1, 2023
|
Thanks @major for your contribution. However, we decided we will drop the |
3 tasks
3 tasks
|
@major, as shown in Azure/azure-cli-extensions#6575 (comment) and #26797 (comment) we would want to keep the dependency on It'll be great if you can recreate the branch and reopen this PR, so that we can give you credit for submitting this PR. Thanks! |
|
@jiasli Will do. Thank you. |
major
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
N/A
Description
Many Linux distributions, including Fedora, have updated to semver 3.0.x. It would be helpful if azure-cli could use this newer version.
Testing Guide
No testing changes needed.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.