{ARM} Fix race condition in bicep unit tests #26797
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
ARM |
ghost
requested a review
from 
ghost
added
the
ARM
|
@jiasli @zhoxing-ms Could you take a look? |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Well, looks like azure-cli-extensions now has a dependency on |
Okay, this can avoid causing breaking changes to other dependent places |
shenglol
changed the title
semver with packaging.version
Since we cannot remove the |
|
@shenglol Actually, I think we can skip removing |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
To clarify, Bicep CLI is technically using semantic versioning. The version is set by Nerdbank.GitVersioning, which produces semver-compatible versions. Currently, for public releases, the version is always in the format of MAJOR.MINOR.PATCH and is also compatible with PEP 440. However, in the future, we might want to publish private or pre-release versions that may contain suffixes (e.g., commit hashes) that are not necessarily compatible with PEP 440. |
|
@jiasli Could you please help review this PR? |
| semver_match = re.search(_semver_pattern, text) | ||
| return semver_match.group(0) if semver_match else None | ||
| return semver.VersionInfo.parse(semver_match.group(0)) if semver_match else None |
There was a problem hiding this comment.
If semver is indeed required, we should consider reviving #26523.
| def setUp(self): | ||
| self.cli_ctx = DummyCli(random_config_dir=True) |
There was a problem hiding this comment.
This contradicts the convention used in #25689 that random_config_dir=True is set in super().__init__ invocation:
There was a problem hiding this comment.
Its superclass is unittest.TestCase, which does not has random_config_dir param.
Related command
az bicep *Description
This main purpose of the PR is to reduce Azure CLI’s packaging maintenance overheads based on @jiasli's feedback #16857 (comment).The PR also fixes race conditions in
test_resource_bicep.pyby having each test uses their ownDummyCliinstance withrandom_config_dirset toTrue.Testing Guide
The existing tests should be sufficient the cover the changes.
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.