[Bugfix] Microphone lobby fix #3896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmceachernmsft
requested review from
JamesBurnside,
alkwa-msft,
carocao-msft,
edwardlee-msft,
PorterNan,
mgamis-msft,
prabhjot-msft,
AmyL219,
jimchou-dev,
vhuseinova-msft,
Leah-Xia-Microsoft,
jpeng-ms,
waynemo,
emlynmac,
JoshuaLai and
palatter
Calling bundle size is decreased✅.
|
Chat bundle size is decreased✅.
|
CallWithChat bundle size is decreased✅.
|
@azure/communication-react jest test coverage for stable.
|
@azure/communication-react jest test coverage for beta.
|
JamesBurnside
approved these changes
Dec 8, 2023
packages/react-composites/src/composites/CallComposite/components/buttons/Microphone.tsx
Outdated
Show resolved
Hide resolved
JamesBurnside
approved these changes
Dec 8, 2023
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
dmceachernmsft
added
the
update_snapshots
github-actions
bot
removed
the
update_snapshots
mgamis-msft
reviewed
Dec 9, 2023
packages/react-composites/src/composites/CallComposite/components/buttons/Microphone.tsx
Outdated
Show resolved
Hide resolved
…com/Azure/communication-ui-library into dmceachernmsft/microphone-lobby-fix
mgamis-msft
reviewed
Dec 9, 2023
| @@ -41,8 +41,7 @@ export const Microphone = (props: { | |||
| * When call is in Lobby, microphone button should be disabled. | |||
| * This is due to to headless limitation where a call can not be muted/unmuted in lobby. | |||
| */ | |||
| if (_isInLobbyOrConnecting(callStatus)) { | |||
| microphoneButtonProps.disabled = true; | |||
| if (callStatus === 'Connecting') { | |||
| // Lobby page should show the microphone status that was set on the local preview/configuration | |||
| // page until the user successfully joins the call. | |||
| microphoneButtonProps.checked = isLocalMicrophoneEnabled; | |||
There was a problem hiding this comment.
Not related to this PR but getLocalMicrophoneEnabled selector should be changed to getLocalMicrophoneOn or something. The verb 'enabled' makes it sound like it should decide if the button is enabled/disabled.
mgamis-msft
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update disabled state to make sure that the lobby state allows for muting and unmuting
Why
Gives the user more control on the lobby screen
https://skype.visualstudio.com/SPOOL/_workitems/edit/3520938
How Tested
Validating locally