Enhance FRR daemon readiness monitoring with detailed diagnostics#1966
Open
ypcisco wants to merge 1 commit intoAzure:202506from
Open
Enhance FRR daemon readiness monitoring with detailed diagnostics#1966ypcisco wants to merge 1 commit intoAzure:202506from
ypcisco wants to merge 1 commit intoAzure:202506from
Conversation
Signed-off-by: Yash Pandit <ypcisco@gmail.com>
anish-n
reviewed
Feb 12, 2026
Contributor
anish-n
left a comment
anish-n
left a comment
There was a problem hiding this comment.
Could we add to the PR description in what condition does zebra take > 20s to start?
| """ | ||
| stop_time = datetime.datetime.now() + datetime.timedelta(seconds=seconds) | ||
| log_info("Start waiting for FRR daemons: %s" % str(datetime.datetime.now())) | ||
| timeout = max(seconds, 120) |
Contributor
There was a problem hiding this comment.
can we please modify the timeout value passed in by the caller instead of introducing a 2nd concept of timeout+max here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
In scenarios where zebra daemon takes longer than 20 seconds to start, bgpcfgd was timing out and exiting. When zebra eventually came up, bgpcfgd was no longer running, resulting in BGP configurations not being pushed. This change increases the minimum timeout and adds detailed logging to diagnose such startup timing issues.
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)