Fix hostname type checking for fanout devices for new sonic-mgmt docker images#1027
Open
eyakubch wants to merge 1 commit intoAzure:202506from
Open
Fix hostname type checking for fanout devices for new sonic-mgmt docker images#1027eyakubch wants to merge 1 commit intoAzure:202506from
eyakubch wants to merge 1 commit intoAzure:202506from
Conversation
Signed-off-by: Eduard Yakubchyk <eyakubch@cisco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With latest sonic-mgmt docker image when run regression we are facing with such error
Solution
The fix is present in public sonic-mgmt:tests/common/cache/facts_cache.py
https://github.com/sonic-net/sonic-mgmt/pull/21729/changes#diff-96c915e519e2a2620baa4625d4d65a21a8dfc46423c1334d39be729bd3c60e56
Need to port this changes to msft-sonic-mgmt
This fixes the issue where type(hostname) not in [str, unicode_type] fails because type() doesn't handle inheritance properly, while isinstance(hostname, (str, unicode_type)) works correctly across Python versions .