Skip to content

Fix hostname type checking for fanout devices for new sonic-mgmt docker images #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eyakubch wants to merge 1 commit into
base: 202506
Choose a base branch
from
Open

Fix hostname type checking for fanout devices for new sonic-mgmt docker images #1027

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/common/cache/facts_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ def _get_default_zone(function, func_args, func_kargs):
unicode_type = str if sys.version_info.major >= 3 else unicode # noqa: F821
if func_args:
hostname = getattr(func_args[0], "hostname", None)
if not hostname or type(hostname) not in [str, unicode_type]:
if not hostname or not isinstance(hostname, (str, unicode_type)):
raise ValueError("Failed to get attribute 'hostname' of type string from instance of type %s."
% type(func_args[0]))
zone = hostname
Expand Down