[action] [PR:20764] Fix SONiC PFC storm generation script on Arista devices#1035
Merged
mssonicbld merged 1 commit intoAzure:202503from Feb 23, 2026
Merged
Conversation
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fix SONiC PFC storm generation script on Arista devices. The PFC generation script needs to enable PFC on the fanout. However, in our fanout configuration. PORT_QOS_MAP is not configured by default. So the following code will return an error, and won't do anything. ``` admin@str5-7060x6-moby-512-fan-2:~$ sudo config interface pfc priority Ethernet88 4 on Cannot find interface Ethernet88 admin@str5-7060x6-moby-512-fan-2:~$ ``` ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? Fix the script error for Arista SONiC fanout. #### How did you do it? This script will only be called on fanout, the new change includes: 1. create the PORT_QOS_MAP entry before calling `config interface pfc priority {intf} {prio} on` 2. Remove the PORT_QOS_MAP when stopping pfc storm, 3. For SONiC fanout, use self._shellCmd() instead of incorrect self._cliCmd() when disabling PFC. #### How did you verify/test it? On local testbed. #### Any platform specific information? Arista SONiC fanout only. #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
Collaborator
Author
|
Original PR: sonic-net/sonic-mgmt#20764 |
Collaborator
Author
|
/azp run |
11 tasks
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fix SONiC PFC storm generation script on Arista devices.
The PFC generation script needs to enable PFC on the fanout. However, in our fanout configuration. PORT_QOS_MAP is not configured by default. So the following code will return an error, and won't do anything.
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix the script error for Arista SONiC fanout.
How did you do it?
This script will only be called on fanout, the new change includes:
config interface pfc priority {intf} {prio} onHow did you verify/test it?
On local testbed.
Any platform specific information?
Arista SONiC fanout only.
Supported testbed topology if it's a new test case?
Documentation