Fix SONiC PFC storm generation script on Arista devices by sdszhang · Pull Request #20764 · sonic-net/sonic-mgmt

sdszhang · 2025-09-22T13:31:15Z

Description of PR

Summary:
Fix SONiC PFC storm generation script on Arista devices.

The PFC generation script needs to enable PFC on the fanout. However, in our fanout configuration. PORT_QOS_MAP is not configured by default. So the following code will return an error, and won't do anything.

admin@str5-7060x6-moby-512-fan-2:~$ sudo config interface pfc priority Ethernet88 4 on
Cannot find interface Ethernet88
admin@str5-7060x6-moby-512-fan-2:~$

Type of change

Back port request

Approach

What is the motivation for this PR?

Fix the script error for Arista SONiC fanout.

How did you do it?

This script will only be called on fanout, the new change includes:

create the PORT_QOS_MAP entry before calling config interface pfc priority {intf} {prio} on
Remove the PORT_QOS_MAP when stopping pfc storm,
For SONiC fanout, use self._shellCmd() instead of incorrect self._cliCmd() when disabling PFC.

How did you verify/test it?

On local testbed.

Any platform specific information?

Arista SONiC fanout only.

Supported testbed topology if it's a new test case?

Documentation

mssonicbld · 2025-09-22T13:31:23Z

/azp run

azure-pipelines · 2025-09-22T13:31:40Z

Azure Pipelines successfully started running 1 pipeline(s).

sdszhang · 2025-09-22T13:32:21Z

@veronica-arista @lipxu @XuChen-MSFT can you help to review?

@rick-arista @davidm-arista @r12f for viz.

tests/common/helpers/pfc_gen_brcm_xgs.py

rick-arista · 2025-09-23T16:23:26Z

LGTM

veronica-arista · 2025-09-23T16:28:03Z

Also looks good to me since we do not have any testbed with Sonic fanout devices.

If anyone is running fanouts with Sonic that are configured differently than the Microsoft set-up, redis-cli -n 4 DEL "PORT_QOS_MAP|{intf}" may interfere with their normal settings.

sdszhang · 2025-09-24T11:59:54Z

Also looks good to me since we do not have any testbed with Sonic fanout devices.

If anyone is running fanouts with Sonic that are configured differently than the Microsoft set-up, redis-cli -n 4 DEL "PORT_QOS_MAP|{intf}" may interfere with their normal settings.

It's a good point. We can handle it in another PR later if different type of config is found.

StormLiangMS

LGTM

…0764) This script will only be called on fanout, the new change includes: create the PORT_QOS_MAP entry before calling config interface pfc priority {intf} {prio} on Remove the PORT_QOS_MAP when stopping pfc storm, For SONiC fanout, use self._shellCmd() instead of incorrect self._cliCmd() when disabling PFC. How did you verify/test it? On local testbed. Any platform specific information? Arista SONiC fanout only.

mssonicbld · 2025-09-26T03:41:29Z

Cherry-pick PR to 202505: #20830

This script will only be called on fanout, the new change includes: create the PORT_QOS_MAP entry before calling config interface pfc priority {intf} {prio} on Remove the PORT_QOS_MAP when stopping pfc storm, For SONiC fanout, use self._shellCmd() instead of incorrect self._cliCmd() when disabling PFC. How did you verify/test it? On local testbed. Any platform specific information? Arista SONiC fanout only.

…0764) This script will only be called on fanout, the new change includes: create the PORT_QOS_MAP entry before calling config interface pfc priority {intf} {prio} on Remove the PORT_QOS_MAP when stopping pfc storm, For SONiC fanout, use self._shellCmd() instead of incorrect self._cliCmd() when disabling PFC. How did you verify/test it? On local testbed. Any platform specific information? Arista SONiC fanout only.

…0764) This script will only be called on fanout, the new change includes: create the PORT_QOS_MAP entry before calling config interface pfc priority {intf} {prio} on Remove the PORT_QOS_MAP when stopping pfc storm, For SONiC fanout, use self._shellCmd() instead of incorrect self._cliCmd() when disabling PFC. How did you verify/test it? On local testbed. Any platform specific information? Arista SONiC fanout only. Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>

…0764) This script will only be called on fanout, the new change includes: create the PORT_QOS_MAP entry before calling config interface pfc priority {intf} {prio} on Remove the PORT_QOS_MAP when stopping pfc storm, For SONiC fanout, use self._shellCmd() instead of incorrect self._cliCmd() when disabling PFC. How did you verify/test it? On local testbed. Any platform specific information? Arista SONiC fanout only. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…0764) This script will only be called on fanout, the new change includes: create the PORT_QOS_MAP entry before calling config interface pfc priority {intf} {prio} on Remove the PORT_QOS_MAP when stopping pfc storm, For SONiC fanout, use self._shellCmd() instead of incorrect self._cliCmd() when disabling PFC. How did you verify/test it? On local testbed. Any platform specific information? Arista SONiC fanout only. Signed-off-by: Aharon Malkin <amalkin@nvidia.com>

…0764) This script will only be called on fanout, the new change includes: create the PORT_QOS_MAP entry before calling config interface pfc priority {intf} {prio} on Remove the PORT_QOS_MAP when stopping pfc storm, For SONiC fanout, use self._shellCmd() instead of incorrect self._cliCmd() when disabling PFC. How did you verify/test it? On local testbed. Any platform specific information? Arista SONiC fanout only. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…0764) This script will only be called on fanout, the new change includes: create the PORT_QOS_MAP entry before calling config interface pfc priority {intf} {prio} on Remove the PORT_QOS_MAP when stopping pfc storm, For SONiC fanout, use self._shellCmd() instead of incorrect self._cliCmd() when disabling PFC. How did you verify/test it? On local testbed. Any platform specific information? Arista SONiC fanout only.

…0764) This script will only be called on fanout, the new change includes: create the PORT_QOS_MAP entry before calling config interface pfc priority {intf} {prio} on Remove the PORT_QOS_MAP when stopping pfc storm, For SONiC fanout, use self._shellCmd() instead of incorrect self._cliCmd() when disabling PFC. How did you verify/test it? On local testbed. Any platform specific information? Arista SONiC fanout only. Signed-off-by: YiFan Wang <yifan@nexthop.ai>

…0764) This script will only be called on fanout, the new change includes: create the PORT_QOS_MAP entry before calling config interface pfc priority {intf} {prio} on Remove the PORT_QOS_MAP when stopping pfc storm, For SONiC fanout, use self._shellCmd() instead of incorrect self._cliCmd() when disabling PFC. How did you verify/test it? On local testbed. Any platform specific information? Arista SONiC fanout only. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…0764) This script will only be called on fanout, the new change includes: create the PORT_QOS_MAP entry before calling config interface pfc priority {intf} {prio} on Remove the PORT_QOS_MAP when stopping pfc storm, For SONiC fanout, use self._shellCmd() instead of incorrect self._cliCmd() when disabling PFC. How did you verify/test it? On local testbed. Any platform specific information? Arista SONiC fanout only. Signed-off-by: Lakshmi Yarramaneni <lakshmi@nexthop.ai>

…0764) This script will only be called on fanout, the new change includes: create the PORT_QOS_MAP entry before calling config interface pfc priority {intf} {prio} on Remove the PORT_QOS_MAP when stopping pfc storm, For SONiC fanout, use self._shellCmd() instead of incorrect self._cliCmd() when disabling PFC. How did you verify/test it? On local testbed. Any platform specific information? Arista SONiC fanout only. Signed-off-by: Yael Tzur <ytzur@nvidia.com>

…0764) This script will only be called on fanout, the new change includes: create the PORT_QOS_MAP entry before calling config interface pfc priority {intf} {prio} on Remove the PORT_QOS_MAP when stopping pfc storm, For SONiC fanout, use self._shellCmd() instead of incorrect self._cliCmd() when disabling PFC. How did you verify/test it? On local testbed. Any platform specific information? Arista SONiC fanout only.

mssonicbld · 2026-02-23T06:01:58Z

Cherry-pick PR to msft-202503: Azure/sonic-mgmt.msft#1035

remote PORT_QOS_MAP key to stop pfc completely.

df7fe24

lipxu reviewed Sep 23, 2025

View reviewed changes

tests/common/helpers/pfc_gen_brcm_xgs.py Show resolved Hide resolved

tests/common/helpers/pfc_gen_brcm_xgs.py Show resolved Hide resolved

lipxu approved these changes Sep 25, 2025

View reviewed changes

sdszhang added the Request for 202505 branch label Sep 25, 2025

StormLiangMS approved these changes Sep 25, 2025

View reviewed changes

StormLiangMS merged commit 83918cc into sonic-net:master Sep 25, 2025
20 checks passed

yejianquan added the Approved for 202505 branch label Sep 26, 2025

mssonicbld added the Created PR to 202505 branch label Sep 26, 2025

mssonicbld mentioned this pull request Sep 26, 2025

[action] [PR:20764] Fix SONiC PFC storm generation script on Arista devices #20830

Merged

11 tasks

mssonicbld added Included in 202505 branch and removed Created PR to 202505 branch labels Sep 26, 2025

sdszhang added the Request for msft-202503 Branch label Feb 15, 2026

bingwang-ms added the Approved for msft-202503 Branch label Feb 23, 2026

mssonicbld mentioned this pull request Feb 23, 2026

[action] [PR:20764] Fix SONiC PFC storm generation script on Arista devices Azure/sonic-mgmt.msft#1035

Merged

11 tasks

mssonicbld added the Created PR to msft-202503 Branch label Feb 23, 2026

mssonicbld added Included in msft-202503 Branch and removed Created PR to msft-202503 Branch labels Feb 23, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Fix SONiC PFC storm generation script on Arista devices#20764

Fix SONiC PFC storm generation script on Arista devices#20764
StormLiangMS merged 1 commit intosonic-net:masterfrom
sdszhang:pfc_gen_th5_sonic

sdszhang commented Sep 22, 2025 •

edited

Loading

Uh oh!

mssonicbld commented Sep 22, 2025

Uh oh!

azure-pipelines bot commented Sep 22, 2025

Uh oh!

sdszhang commented Sep 22, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

rick-arista commented Sep 23, 2025

Uh oh!

veronica-arista commented Sep 23, 2025

Uh oh!

sdszhang commented Sep 24, 2025

Uh oh!

StormLiangMS left a comment

Uh oh!

Uh oh!

mssonicbld commented Sep 26, 2025

Uh oh!

mssonicbld commented Feb 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Comments

Conversation

sdszhang commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Sep 22, 2025

Uh oh!

azure-pipelines bot commented Sep 22, 2025

Uh oh!

sdszhang commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rick-arista commented Sep 23, 2025

Uh oh!

veronica-arista commented Sep 23, 2025

Uh oh!

sdszhang commented Sep 24, 2025

Uh oh!

StormLiangMS left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mssonicbld commented Sep 26, 2025

Uh oh!

mssonicbld commented Feb 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

sdszhang commented Sep 22, 2025 •

edited

Loading

sdszhang commented Sep 22, 2025 •

edited

Loading