Skip to content

Comments

[action] [PR:20764] Fix SONiC PFC storm generation script on Arista devices#20830

Merged
mssonicbld merged 1 commit intosonic-net:202505from
mssonicbld:cherry/202505/20764
Sep 26, 2025
Merged

[action] [PR:20764] Fix SONiC PFC storm generation script on Arista devices#20830
mssonicbld merged 1 commit intosonic-net:202505from
mssonicbld:cherry/202505/20764

Conversation

@mssonicbld
Copy link
Collaborator

Description of PR

Summary:
Fix SONiC PFC storm generation script on Arista devices.

The PFC generation script needs to enable PFC on the fanout. However, in our fanout configuration. PORT_QOS_MAP is not configured by default. So the following code will return an error, and won't do anything.

admin@str5-7060x6-moby-512-fan-2:~$ sudo config interface pfc priority Ethernet88 4 on
Cannot find interface Ethernet88
admin@str5-7060x6-moby-512-fan-2:~$ 

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
  • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

Fix the script error for Arista SONiC fanout.

How did you do it?

This script will only be called on fanout, the new change includes:

  1. create the PORT_QOS_MAP entry before calling config interface pfc priority {intf} {prio} on
  2. Remove the PORT_QOS_MAP when stopping pfc storm,
  3. For SONiC fanout, use self._shellCmd() instead of incorrect self._cliCmd() when disabling PFC.

How did you verify/test it?

On local testbed.

Any platform specific information?

Arista SONiC fanout only.

Supported testbed topology if it's a new test case?

Documentation

…0764)

This script will only be called on fanout, the new change includes:

create the PORT_QOS_MAP entry before calling config interface pfc priority {intf} {prio} on
Remove the PORT_QOS_MAP when stopping pfc storm,
For SONiC fanout, use self._shellCmd() instead of incorrect self._cliCmd() when disabling PFC.
How did you verify/test it?
On local testbed.

Any platform specific information?
Arista SONiC fanout only.
@mssonicbld
Copy link
Collaborator Author

Original PR: #20764

@mssonicbld
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit 2f8c699 into sonic-net:202505 Sep 26, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants