Skip to content

Fix health check for SSD vendors: add a parser for ATP, and add a gen…#106

Closed
markx-arista wants to merge 1 commit intoAzure:202412from
markx-arista:fix-health-check-for-atp-and-generic-ssds
Closed

Fix health check for SSD vendors: add a parser for ATP, and add a gen…#106
markx-arista wants to merge 1 commit intoAzure:202412from
markx-arista:fix-health-check-for-atp-and-generic-ssds

Conversation

@markx-arista
Copy link

Description

Fix health check for SSD vendors: add a parser for ATP, and add a generic health ID for other brands.
Each vendor stores health information in different SMART attributes.
ATP stores it in attribute ID 248, we add a parser for it.
We also have SSDs use Attribute ID 231 and it is commonly used, so add it in the generic parser.
Skip obtaining vendor SSD info for ATP and Virtium NVMe SSD because they are handle by parse_generic_ssd_info and parse_vendor_ssd_info will overwrite data with N/A.
Add unit test cases for ATP SATA/NVMe SSD.

Motivation and Context

show platform ssdhealth shows N/A health for some qualified SSDs.

Back port request

  • 202412

How Has This Been Tested?

We have tested the code change on DUTs with different SSDs including all the qualified SSDs that show N/A in health and also on the ones that worked fine before.

…eric health ID for other brands.

Also add corresponding unit test cases.
@markx-arista
Copy link
Author

@markx-arista please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Arista"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant