[action] [PR:1694] [syncd] Remove syncd redis objects if using ZMQ notifications#100
Merged
mssonicbld merged 1 commit intoAzure:202506from Jan 15, 2026
Merged
Conversation
Turns off creating entries in redis for syncd if ZMQ is enabled. This new behavior only occurs when ZMQ_sync is enabled, which is currently only used in the nvidia-bluefield platforms (DPUs in SmartSwitch Scenario). This PR reduces size of ASIC_DB to prevent an issue where running show techsupport with large numbers of ENIs would be degraded and lead to syncd crashing. With enough ENIs (roughly 63) SONiC would run out of free memory altogether and crash. This also leads to performance improvements as the redis entries are redundant as the SaiRedis notifications are redundant as the notifications are already received over the ZMQ message queue in the syncd ZMQ_sync mode. VS Switches will need to have the old behavior for unit testing otherwise swss tests will fail
Collaborator
Author
|
Original PR: sonic-net/sonic-sairedis#1694 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns off creating entries in redis for syncd if ZMQ is enabled. This new behavior only occurs when ZMQ_sync is enabled, which is currently only used in the nvidia-bluefield platforms (DPUs in SmartSwitch Scenario).
This PR reduces size of ASIC_DB to prevent an issue where running show techsupport with large numbers of ENIs would be degraded and lead to syncd crashing. With enough ENIs (roughly 63) SONiC would run out of free memory altogether and crash. This also leads to performance improvements as the redis entries are redundant as the SaiRedis notifications are redundant as the notifications are already received over the ZMQ message queue in the syncd ZMQ_sync mode.
VS Switches will need to have the old behavior for unit testing otherwise swss tests will fail