[syncd] Remove syncd redis objects if using ZMQ notifications by croos12 · Pull Request #1694 · sonic-net/sonic-sairedis

croos12 · 2025-11-13T05:48:38Z

Turns off creating entries in redis for syncd if ZMQ is enabled. This new behavior only occurs when ZMQ_sync is enabled, which is currently only used in the nvidia-bluefield platforms (DPUs in SmartSwitch Scenario).

This PR reduces size of ASIC_DB to prevent an issue where running show techsupport with large numbers of ENIs would be degraded and lead to syncd crashing. With enough ENIs (roughly 63) SONiC would run out of free memory altogether and crash. This also leads to performance improvements as the redis entries are redundant as the SaiRedis notifications are redundant as the notifications are already received over the ZMQ message queue in the syncd ZMQ_sync mode.

VS Switches will need to have the old behavior for unit testing otherwise swss tests will fail

Signed-off-by: Connor Roos <croos@nvidia.com>

Since we no longer use redis in zmq_sync mode there is no buffer to sync Signed-off-by: Connor Roos <croos@nvidia.com>

mssonicbld · 2025-11-13T05:48:46Z

/azp run

azure-pipelines · 2025-11-13T05:48:52Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

mssonicbld · 2025-11-13T05:48:53Z

/azp run

azure-pipelines · 2025-11-13T05:49:05Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-11-13T06:36:42Z

/azp run

azure-pipelines · 2025-11-13T06:36:52Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-11-13T16:54:48Z

/azp run

azure-pipelines · 2025-11-13T16:54:59Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-11-13T16:55:32Z

/azp run

azure-pipelines · 2025-11-13T16:55:43Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-11-13T17:38:49Z

/azp run

azure-pipelines · 2025-11-13T17:39:00Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-11-13T17:39:09Z

/azp run

azure-pipelines · 2025-11-13T17:39:20Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Connor Roos <croos@nvidia.com>

mssonicbld · 2025-11-13T18:37:22Z

/azp run

azure-pipelines · 2025-11-13T18:37:33Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-11-13T18:37:37Z

/azp run

azure-pipelines · 2025-11-13T18:37:48Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2026-01-13T22:22:40Z

Azure Pipelines successfully started running 1 pipeline(s).

croos12 · 2026-01-14T02:43:37Z

@prabhataravind I addressed the Copilot comments

prabhataravind

lgtm

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

syncd/tests/TestDisabledRedisClient.cpp

Signed-off-by: Connor Roos <croos@nvidia.com>

mssonicbld · 2026-01-14T19:37:01Z

/azp run

azure-pipelines · 2026-01-14T19:37:14Z

Azure Pipelines successfully started running 1 pipeline(s).

lolyu

LGTM

lolyu · 2026-01-15T02:50:38Z

Hi @saiarcot895, could you please review again?

prsunny · 2026-01-15T02:57:45Z

@saiarcot895 , please merge

prsunny · 2026-01-15T03:00:06Z

@croos12 , thanks for the PR

mssonicbld · 2026-01-15T03:02:25Z

Cherry-pick PR to msft-202506: Azure/sonic-sairedis.msft#100

mssonicbld · 2026-01-15T03:02:44Z

Cherry-pick PR to 202511: #1738

…net#1694) * Remove syncd redis objects if using ZMQ notifications Signed-off-by: Connor Roos <croos@nvidia.com> * Remove trailing whitespace in RedisClient.cpp Signed-off-by: Connor Roos <croos@nvidia.com> * Ignore Syncd::applyView() if ZMQ if enabled Signed-off-by: Connor Roos <croos@nvidia.com> * Create empty applyview.log for unittest if ZMQ Signed-off-by: Connor Roos <croos@nvidia.com> * Remove zmq_sync buffer_pools tests Since we no longer use redis in zmq_sync mode there is no buffer to sync Signed-off-by: Connor Roos <croos@nvidia.com> * Set Redis entries to be created in vs ASIC Signed-off-by: Connor Roos <croos@nvidia.com> * Set default value and flag for is virtual switch Signed-off-by: Connor Roos <croos@nvidia.com> * Undo flag changes Signed-off-by: Connor Roos <croos@nvidia.com> * Switch to checking VendorSAI type Signed-off-by: Connor Roos <croos@nvidia.com> * Link with SAILIB Signed-off-by: Connor Roos <croos@nvidia.com> * Try to use profile map instead of vendorSai type Signed-off-by: Connor Roos <croos@nvidia.com> * Set test for disabled RedisClient Signed-off-by: Connor Roos <croos@nvidia.com> * Revert zmq_sync buffer_pool test removal Signed-off-by: Connor Roos <croos@nvidia.com> * Add isRedisDisabled method Makes redis disable more legible and adds methods to determine whether or not to create error logs Signed-off-by: Connor Roos <croos@nvidia.com> * Use dependency injection to disable Signed-off-by: Connor Roos <croos@nvidia.com> * Included RedisClient Header file Signed-off-by: Connor Roos <croos@nvidia.com> * Add one more missing #include Signed-off-by: Connor Roos <croos@nvidia.com> * Remove whitespace Signed-off-by: Connor Roos <croos@nvidia.com> * Address copilot comments Signed-off-by: Connor Roos <croos@nvidia.com> * Add getVidsForRids change to DisabledRedisClient Signed-off-by: Connor Roos <croos@nvidia.com> * Fix isRedisEnabled calls Signed-off-by: Connor Roos <croos@nvidia.com> * Fix whitespace Signed-off-by: Connor Roos <croos@nvidia.com> * Address Copilot comments for test Signed-off-by: Connor Roos <croos@nvidia.com> --------- Signed-off-by: Connor Roos <croos@nvidia.com> Co-authored-by: prabhataravind <108555774+prabhataravind@users.noreply.github.com> Co-authored-by: Longxiang Lyu <35479537+lolyu@users.noreply.github.com>

mssonicbld · 2026-01-23T23:14:17Z

@croos12 cherry pick PR didn't pass PR checker. Please check!!!
#1738

croos12 and others added 7 commits October 27, 2025 20:29

Remove syncd redis objects if using ZMQ notifications

9bcdefe

Signed-off-by: Connor Roos <croos@nvidia.com>

Remove trailing whitespace in RedisClient.cpp

b337132

Signed-off-by: Connor Roos <croos@nvidia.com>

Merge branch 'master' into redis_disabled_if_ZMQ

d21a70f

Ignore Syncd::applyView() if ZMQ if enabled

4c4e6a6

Signed-off-by: Connor Roos <croos@nvidia.com>

Create empty applyview.log for unittest if ZMQ

c3271a1

Signed-off-by: Connor Roos <croos@nvidia.com>

Remove zmq_sync buffer_pools tests

f35bcfc

Since we no longer use redis in zmq_sync mode there is no buffer to sync Signed-off-by: Connor Roos <croos@nvidia.com>

Merge branch 'master' into redis_disabled_if_ZMQ

38a46f7

croos12 force-pushed the redis_disabled_if_ZMQ branch from d0df908 to f252482 Compare November 13, 2025 16:54

croos12 force-pushed the redis_disabled_if_ZMQ branch from 0ee1ea9 to 541ef03 Compare November 13, 2025 17:38

Set Redis entries to be created in vs ASIC

d945839

Signed-off-by: Connor Roos <croos@nvidia.com>

croos12 force-pushed the redis_disabled_if_ZMQ branch from be9ca92 to d945839 Compare November 13, 2025 18:37

Merge branch 'master' into redis_disabled_if_ZMQ

d580753

prabhataravind previously approved these changes Jan 14, 2026

View reviewed changes

prabhataravind requested a review from Copilot January 14, 2026 14:12

Copilot started reviewing on behalf of prabhataravind January 14, 2026 14:13 View session

Copilot AI reviewed Jan 14, 2026

View reviewed changes

syncd/tests/TestDisabledRedisClient.cpp Outdated Show resolved Hide resolved

syncd/tests/TestDisabledRedisClient.cpp Show resolved Hide resolved

syncd/tests/TestDisabledRedisClient.cpp Show resolved Hide resolved

Address Copilot comments for test

f2cc7f7

Signed-off-by: Connor Roos <croos@nvidia.com>

croos12 dismissed prabhataravind’s stale review via f2cc7f7 January 14, 2026 19:36

lolyu approved these changes Jan 15, 2026

View reviewed changes

saiarcot895 approved these changes Jan 15, 2026

View reviewed changes

prsunny added the Approved for 202511 Branch label Jan 15, 2026

saiarcot895 merged commit 914bda7 into sonic-net:master Jan 15, 2026
16 checks passed

mssonicbld mentioned this pull request Jan 15, 2026

[action] [PR:1694] [syncd] Remove syncd redis objects if using ZMQ notifications Azure/sonic-sairedis.msft#100

Merged

mssonicbld added the Created PR to msft-202506 Branch label Jan 15, 2026

mssonicbld mentioned this pull request Jan 15, 2026

[action] [PR:1694] [syncd] Remove syncd redis objects if using ZMQ notifications #1738

Merged

mssonicbld added the Created PR to 202511 Branch label Jan 15, 2026

mssonicbld added Included in msft-202506 Branch and removed Created PR to msft-202506 Branch labels Jan 15, 2026

mssonicbld added Included in 202511 Branch and removed Created PR to 202511 Branch labels Jan 24, 2026

Comments

Conversation

croos12 commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mssonicbld commented Nov 13, 2025

Uh oh!

azure-pipelines bot commented Nov 13, 2025

Uh oh!

mssonicbld commented Nov 13, 2025

Uh oh!

azure-pipelines bot commented Nov 13, 2025

Uh oh!

mssonicbld commented Nov 13, 2025

Uh oh!

azure-pipelines bot commented Nov 13, 2025

Uh oh!

mssonicbld commented Nov 13, 2025

Uh oh!

azure-pipelines bot commented Nov 13, 2025

Uh oh!

mssonicbld commented Nov 13, 2025

Uh oh!

azure-pipelines bot commented Nov 13, 2025

Uh oh!

mssonicbld commented Nov 13, 2025

Uh oh!

azure-pipelines bot commented Nov 13, 2025

Uh oh!

mssonicbld commented Nov 13, 2025

Uh oh!

azure-pipelines bot commented Nov 13, 2025

Uh oh!

mssonicbld commented Nov 13, 2025

Uh oh!

azure-pipelines bot commented Nov 13, 2025

Uh oh!

mssonicbld commented Nov 13, 2025

Uh oh!

azure-pipelines bot commented Nov 13, 2025

Uh oh!

azure-pipelines bot commented Jan 13, 2026

Uh oh!

croos12 commented Jan 14, 2026

Uh oh!

prabhataravind left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mssonicbld commented Jan 14, 2026

Uh oh!

azure-pipelines bot commented Jan 14, 2026

Uh oh!

lolyu left a comment

Choose a reason for hiding this comment

Uh oh!

lolyu commented Jan 15, 2026

Uh oh!

prsunny commented Jan 15, 2026

Uh oh!

prsunny commented Jan 15, 2026

Uh oh!

Uh oh!

mssonicbld commented Jan 15, 2026

Uh oh!

mssonicbld commented Jan 15, 2026

Uh oh!

mssonicbld commented Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

croos12 commented Nov 13, 2025 •

edited

Loading