Skip to content

Comments

[action] [PR:4193] [countersyncd] fix otel actor log level#204

Merged
mssonicbld merged 1 commit intoAzure:202412from
mssonicbld:cherry/msft-202412/4193
Feb 9, 2026
Merged

[action] [PR:4193] [countersyncd] fix otel actor log level#204
mssonicbld merged 1 commit intoAzure:202412from
mssonicbld:cherry/msft-202412/4193

Conversation

@mssonicbld
Copy link
Collaborator

What I did

  • Wrapping with log::log_enabled!(log::Level::Debug) avoids the cost of building log output unless Debug is enabled.
  • Changing print_otel_metrics() to Debug level prevents noisy logs in normal operation; it only shows up when debugging.
  • Removing print_to_console simplifies config and relies solely on log levels to control output.
    Why I did it
    Avoids the cost of building log output unless Debug is enabled.
    How I verified it
    Verified in internal setup.
    Details if related

<!--
Please make sure you have read and understood the contribution guildlines:
https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

1. Make sure your commit includes a signature generted with `git commit -s`
2. Make sure your commit title follows the correct format: [component]: description
3. Make sure your commit message contains enough details about the change and related tests
4. Make sure your pull request adds related reviewers, asignees, labels

Please also provide the following information in this pull request:
-->

**What I did**
- Wrapping with log::log_enabled!(log::Level::Debug) avoids the cost of building log output unless Debug is enabled.
- Changing print_otel_metrics() to Debug level prevents noisy logs in normal operation; it only shows up when debugging.
- Removing print_to_console simplifies config and relies solely on log levels to control output.
**Why I did it**
Avoids the cost of building log output unless Debug is enabled.
**How I verified it**
Verified in internal setup.
**Details if related**
@mssonicbld
Copy link
Collaborator Author

Original PR: sonic-net/sonic-swss#4193

@mssonicbld
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@r12f
Copy link

r12f commented Feb 5, 2026

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit b7678f2 into Azure:202412 Feb 9, 2026
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants