[countersyncd] fix otel actor log level #4193
Merged
prsunny merged 3 commits intosonic-net:masterfrom Feb 3, 2026
Merged
Conversation
Signed-off-by: Janet Cui <janet970527@gmail.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
This pull request aims to optimize the OtelActor logging by replacing the print_to_console configuration field with a runtime check using log::log_enabled!(log::Level::Debug). The intention is to avoid the cost of building log output unless Debug level logging is enabled, and to change the logging from Info to Debug level to reduce noise in production.
Changes:
- Replaced the
config.print_to_consolecheck withlog::log_enabled!(log::Level::Debug)to gate the call toprint_otel_metrics() - Changed all logging statements within
print_otel_metrics()frominfo!todebug!level
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Janet Cui <janet970527@gmail.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Pterosaur
reviewed
Feb 3, 2026
Signed-off-by: Janet Cui <janet970527@gmail.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Pterosaur
approved these changes
Feb 3, 2026
prsunny
approved these changes
Feb 3, 2026
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-swss.msft#204 |
Collaborator
|
@Janetxxx cherry pick PR didn't pass PR checker. Please check!!! |
3 similar comments
Collaborator
|
@Janetxxx cherry pick PR didn't pass PR checker. Please check!!! |
Collaborator
|
@Janetxxx cherry pick PR didn't pass PR checker. Please check!!! |
Collaborator
|
@Janetxxx cherry pick PR didn't pass PR checker. Please check!!! |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
Collaborator
|
Cherry-pick PR to 202511: #4221 |
mssonicbld
added
Included in 202511 Branch
and removed
Created PR to 202511 Branch
labels
theasianpianist
pushed a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Feb 17, 2026
What I did Wrapping with log::log_enabled!(log::Level::Debug) avoids the cost of building log output unless Debug is enabled. Changing print_otel_metrics() to Debug level prevents noisy logs in normal operation; it only shows up when debugging. Removing print_to_console simplifies config and relies solely on log levels to control output. Why I did it Avoids the cost of building log output unless Debug is enabled. Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
ksravani-hcl
pushed a commit
to ksravani-hcl/sonic-swss
that referenced
this pull request
Feb 20, 2026
What I did Wrapping with log::log_enabled!(log::Level::Debug) avoids the cost of building log output unless Debug is enabled. Changing print_otel_metrics() to Debug level prevents noisy logs in normal operation; it only shows up when debugging. Removing print_to_console simplifies config and relies solely on log levels to control output. Why I did it Avoids the cost of building log output unless Debug is enabled.
baorliu
pushed a commit
to baorliu/sonic-swss
that referenced
this pull request
Feb 23, 2026
What I did Wrapping with log::log_enabled!(log::Level::Debug) avoids the cost of building log output unless Debug is enabled. Changing print_otel_metrics() to Debug level prevents noisy logs in normal operation; it only shows up when debugging. Removing print_to_console simplifies config and relies solely on log levels to control output. Why I did it Avoids the cost of building log output unless Debug is enabled. Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
ksravani-hcl
pushed a commit
to ksravani-hcl/sonic-swss
that referenced
this pull request
Feb 24, 2026
What I did Wrapping with log::log_enabled!(log::Level::Debug) avoids the cost of building log output unless Debug is enabled. Changing print_otel_metrics() to Debug level prevents noisy logs in normal operation; it only shows up when debugging. Removing print_to_console simplifies config and relies solely on log levels to control output. Why I did it Avoids the cost of building log output unless Debug is enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Why I did it
Avoids the cost of building log output unless Debug is enabled.
How I verified it
Verified in internal setup.
Details if related