Create converts for trimmed surfaces #120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelbaran
added
type:feature
pawelbaran
requested review from
al-fisher,
adecler,
IsakNaslundBh and
epignatelli
pawelbaran
changed the title
This was referenced Nov 4, 2019
FraserGreenroyd
requested changes
Nov 5, 2019
There was a problem hiding this comment.
Hi @pawelbaran same comment for this one as with the engine PR - the branch name eventually needs to match the oM branch for the CI to pass the PR 😄
This was referenced Nov 12, 2019
|
Closing this one and reopening in #122 |
pawelbaran
deleted the
Rhinoceros_Engine-Issue119-CreateConvertsForTrimmedSurfaces
branch
This was referenced Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!!! PLEASE DO NOT MERGE !!!
NOTE: Depends on
#603
#1298
Issues addressed by this PR
Closes #119
Test files
Test file is located on SharePoint. To run it, please switch to the branches related to the following PRs:
The error in the test file is caused by the bug in Cone convert logged here.
Changelog
NurbsSurfacedefinition.Additional comments
Please see #603.
There is still a few hacky workarounds and boilerplate/overhead, to be polished once the architecture is agreed in BHoM.