-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/reference alleles #14
Merged
saramonzon
merged 22 commits into
BU-ISCIII:develop
from
luissian:feature/reference_alleles
Feb 27, 2024
Merged
Feature/reference alleles #14
saramonzon
merged 22 commits into
BU-ISCIII:develop
from
luissian:feature/reference_alleles
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and fetch cluster allele representative
luissian
force-pushed
the
feature/reference_alleles
branch
from
February 5, 2024 15:23
3e56471
to
81efe04
Compare
saramonzon
reviewed
Feb 13, 2024
@@ -26,6 +26,6 @@ jobs: | |||
run: | | |||
source $CONDA/etc/profile.d/conda.sh | |||
conda activate taranis_env | |||
poetry install | |||
python -m pip install . | |||
taranis analyze-schema -i test/MLST_listeria -o analyze_schema_test --cpus 1 --output-allele-annot --remove-no-cds --remove-duplicated --remove-subset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add the test for the reference_alleles functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to finish coding first, as I would like to start using pytest for testing
saramonzon
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of this feature is done by creating 2 additional classes: for getting the candidate alleles
On this PR , reference alleles are selected by choosing an allele for each cluster. The cluster is done using Leigde algorithm that get as input the distance matrix created by mash program. Resolution parameter is used for Leigde algorithm to group neighborhood alleles. The resolution default or user defined value is increased by 0.025 if exists any cluster that the list of the cluster are not the same as got by blast.
Generated files are: